[GitHub] [orc] wgtmac commented on a diff in pull request #1114: ORC-1170:[C++] Optimize the RowReader::seekToRow function in the case of seeking within the same stripe

[GitBox <gi...@apache.org>]

wgtmac commented on code in PR #1114:
URL: https://github.com/apache/orc/pull/1114#discussion_r874287954


##########
c++/include/orc/MemoryPool.hh:
##########
@@ -72,6 +72,10 @@ namespace orc {
       return currentCapacity;
     }
 
+    const T& operator[](uint64_t i) const {
+      return buf[i];
+    }
+

Review Comment:
   suggest to use the trick to remove duplicates between const and non-const overloads: https://stackoverflow.com/questions/123758/how-do-i-remove-code-duplication-between-similar-const-and-non-const-member-func



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org