You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/08 19:55:37 UTC

[GitHub] [spark] BryanCutler commented on a change in pull request #29686: [SPARK-32312][SQL][PYTHON] Upgrade Apache Arrow to version 1.0.1

BryanCutler commented on a change in pull request #29686:
URL: https://github.com/apache/spark/pull/29686#discussion_r485161196



##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -40,7 +40,7 @@ def require_minimum_pyarrow_version():
     """ Raise ImportError if minimum version of pyarrow is not installed
     """
     # TODO(HyukjinKwon): Relocate and deduplicate the version specification.
-    minimum_pyarrow_version = "0.15.1"
+    minimum_pyarrow_version = "1.0.0"

Review comment:
       I also tested against 0.17.1, which is still binary compatible, and all tests pass. So it is not necessary to bump this, but is probably a good idea to set a baseline for future support/maintenance 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org