[jira] [Commented] (SSHD-117) Ignore "keepalive@jcraft.com" in addition to "keepalive@openssh.com"

["Bobby Powers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021750#comment-13021750 ] 

Bobby Powers commented on SSHD-117:
-----------------------------------

we ignore keepalive@lag.net on trunk as well, so this seems like a good idea

> Ignore "keepalive@jcraft.com" in addition to "keepalive@openssh.com"
> --------------------------------------------------------------------
>
>                 Key: SSHD-117
>                 URL: https://issues.apache.org/jira/browse/SSHD-117
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>         Environment: Any environment, JSch based client.
>            Reporter: Bill Kuker
>            Priority: Trivial
>
> It would be nice to also ignore jcraft keepalive messages.
> I think it is silly that this is how keepalive is done, but if MINA SSHD ignores one it may as well ignore the other. 
> sshd-core/src/main/java/org/apache/sshd/server/session/ServerSession.java
> -        if (req.equals("keepalive@openssh.com")) {
> +        if (req.equals("keepalive@openssh.com") || req.equals("keepalive@jcraft.com")) {
> Personally I'd also like to see:
> -        log.error("Unknown global request: {}", req);
> +       log.warn("Unknown global request: {}", req);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira