[GitHub] [incubator-superset] villebro commented on a change in pull request #11437: fix: add init.py to the annotations module

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #11437:
URL: https://github.com/apache/incubator-superset/pull/11437#discussion_r512504839



##########
File path: superset/annotation_layers/annotations/api.py
##########
@@ -116,7 +116,7 @@ class AnnotationRestApi(BaseSupersetModelRestApi):
     openapi_spec_methods = openapi_spec_methods_override
 
     @staticmethod
-    def _apply_layered_relation_to_rison(layer_id: int, rison_parameters) -> None:
+    def _apply_layered_relation_to_rison(layer_id: int, rison_parameters: Any) -> None:

Review comment:
       Nit: I think it's
   ```suggestion
       def _apply_layered_relation_to_rison(layer_id: int, rison_parameters: Dict[str, Any]) -> None:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org