You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by exabrial <gi...@git.apache.org> on 2018/09/22 20:05:01 UTC
[GitHub] tomee pull request #171: [Master Branch] TOMEE-2240 ManagedScheduledExecutor...
GitHub user exabrial opened a pull request:
https://github.com/apache/tomee/pull/171
[Master Branch] TOMEE-2240 ManagedScheduledExecutorService doesn't allow setting max value
Fix https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2240
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exabrial/tomee issues/master_TOMEE-2240_managed-scheduled-exec-service-max-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit ddda42084ab530d73811ec162ffa1c097a41794a
Author: Jonathan S. Fisher <ex...@...>
Date: 2018-09-22T20:04:09Z
Fix https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2240
----
---
[GitHub] tomee issue #171: [Master Branch] TOMEE-2240 ManagedScheduledExecutorService...
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/171
Isnt 5s too small?
Also, dont forget to add new params to service-jar.xml in openejb-core.
Otherwise looks good!
---
[GitHub] tomee issue #171: [Master Branch] TOMEE-2240 ManagedScheduledExecutorService...
Posted by exabrial <gi...@git.apache.org>.
Github user exabrial commented on the issue:
https://github.com/apache/tomee/pull/171
Actually I need to close this! I wrote this patch before I read the javadoc on the scheduled executor service thoroughly. The max setting is a little misleading. When you wrote the original code you left the max out because it doesn't have the intended effect
---
[GitHub] tomee pull request #171: [Master Branch] TOMEE-2240 ManagedScheduledExecutor...
Posted by exabrial <gi...@git.apache.org>.
Github user exabrial closed the pull request at:
https://github.com/apache/tomee/pull/171
---
[GitHub] tomee issue #171: [Master Branch] TOMEE-2240 ManagedScheduledExecutorService...
Posted by rmannibucau <gi...@git.apache.org>.
Github user rmannibucau commented on the issue:
https://github.com/apache/tomee/pull/171
No issue, thanks for taking time to PR and recheck it.
---