You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/21 06:25:44 UTC

[GitHub] [superset] villebro commented on pull request #18817: fix(sql Lab tabs): Empty SQL Lab tabs

villebro commented on pull request #18817:
URL: https://github.com/apache/superset/pull/18817#issuecomment-1046515669


   Thanks for working on this @AAfghahi! I pinged @kgabryje for a review; He's done similar work by introducing a new `EmptyState` component in #18676 which has been rolled out in several follow-up PRs (#18678, #18679, #18681 and #18712). By leveraging a similar approach here we could potentially address @yousoph's observation regarding the blurry empty state and consolidate code that deals with empty states.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org