You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/07 21:08:12 UTC
[GitHub] [helix] alirezazamani opened a new pull request #505: Fix the
scenario for task being Dropped and Assigned in a loop forever
alirezazamani opened a new pull request #505: Fix the scenario for task being Dropped and Assigned in a loop forever
URL: https://github.com/apache/helix/pull/505
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR title:
Fixes #461 .
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This commit specifically targets the scenario where there is massive participant disconnections.
Here a new check has been added to avoid the tasks to be assigned right away to the old instance after participant disconnection and mastership handoff. The tasks will be considered as dropped and re-assigned in next pipeline to the correct instances.
### Tests
Note: This part of the code cannot be reproduced using any tests. It has been tested manually (returning INIT from updateJobContextAndGetTaskCurrentState function when currentState is null.)
- [x] The following is the result of the "mvn test" command on the appropriate module:
Test Result 1: mvn test
[ERROR] Tests run: 883, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3,272.312 s <<< FAILURE! - in TestSuite
[ERROR] testTaskPerformanceMetrics(org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics) Time elapsed: 2.214 s <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
at org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics.testTaskPerformanceMetrics(TestTaskPerformanceMetrics.java:118)
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAlertingRebalancerFailure.testTagSetIncorrect:174->checkResourceBestPossibleCalFailureState:310 expected:<true> but was:<false>
[ERROR] TestTaskPerformanceMetrics.testTaskPerformanceMetrics:118 expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 882, Failures: 2, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58:06 min
[INFO] Finished at: 2019-10-07T13:25:30-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-core: There are test failures.
[ERROR]
[ERROR] Please refer to /home/anajari/my_repos/helix/helix-core/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
Test Result 2: mvn test -Dtest="TestAlertingRebalancerFailure,TestTaskPerformanceMetrics"
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.05 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24.619 s
[INFO] Finished at: 2019-10-07T14:02:40-07:00
[INFO] ------------------------------------------------------------------------
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org