You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 19:25:02 UTC
[GitHub] [airflow] Starefossen opened a new pull request, #26604: Update when not to use helm hooks for starting jobs
Starefossen opened a new pull request, #26604:
URL: https://github.com/apache/airflow/pull/26604
This pull request updates the documentation for the Helm Chart for when not to use the helm hooks for starting migration jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26604: Update docs when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26604:
URL: https://github.com/apache/airflow/pull/26604#issuecomment-1255506683
Added double-backticks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26604: Update docs when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26604:
URL: https://github.com/apache/airflow/pull/26604#discussion_r978049933
##########
docs/helm-chart/index.rst:
##########
@@ -122,13 +122,15 @@ The command removes all the Kubernetes components associated with the chart and
.. note::
Some kubernetes resources created by the chart `helm hooks <https://helm.sh/docs/topics/charts_hooks/#hook-resources-are-not-managed-with-corresponding-releases>`__ might be left in the namespace after executing ``helm uninstall``, for example, ``brokerUrlSecret`` or ``fernetKeySecret``.
-Installing the Chart with Argo CD or Flux
------------------------------------------
+Installing the Chart with Argo CD, Flux or Terraform
+-----------------------------------------------------
-When installing the chart using Argo CD or Flux, you MUST set the two following values, or your application
+When installing the chart using Argo CD, Flux, or Terraform, you MUST set the two following values, or your application
will not start as the migrations will not be run:
.. code-block:: yaml
createUserJob.useHelmHooks: false
migrateDatabaseJob.useHelmHooks: false
+
+This also applies if you install the chart using `--wait` in your `helm install` command.
Review Comment:
```suggestion
This also applies if you install the chart using ``--wait`` in your ``helm install`` command.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26604: Update docs when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26604:
URL: https://github.com/apache/airflow/pull/26604#issuecomment-1256643016
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #26604: Update docs when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #26604:
URL: https://github.com/apache/airflow/pull/26604#issuecomment-1256680804
Thanks @Starefossen! Congrats on your first commit 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26604: Update when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26604:
URL: https://github.com/apache/airflow/pull/26604#issuecomment-1255455688
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #26604: Update docs when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #26604:
URL: https://github.com/apache/airflow/pull/26604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Starefossen commented on pull request #26604: Update docs when not to use helm hooks for starting jobs
Posted by GitBox <gi...@apache.org>.
Starefossen commented on PR #26604:
URL: https://github.com/apache/airflow/pull/26604#issuecomment-1256681779
Thanks to all of _you_ for making Apache AirFlow ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org