You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "zhuoyang (via GitHub)" <gi...@apache.org> on 2023/10/18 15:59:34 UTC
[PR] fix: plugin_metadata_cm path [apisix-helm-chart]
zhuoyang opened a new pull request, #646:
URL: https://github.com/apache/apisix-helm-chart/pull/646
It is supposed to be on root level instead of under kubernetes
https://github.com/apache/apisix-ingress-controller/blob/0736bba3f3bda0d47620ef1c6414f73d5b2056e5/pkg/config/config.go#L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin_metadata_cm path [apisix-helm-chart]
Posted by "indrekj (via GitHub)" <gi...@apache.org>.
indrekj commented on PR #646:
URL: https://github.com/apache/apisix-helm-chart/pull/646#issuecomment-1773119474
> Yes, welcome to create a PR.
Ok, done: https://github.com/apache/apisix-helm-chart/pull/648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin_metadata_cm path [apisix-helm-chart]
Posted by "indrekj (via GitHub)" <gi...@apache.org>.
indrekj commented on PR #646:
URL: https://github.com/apache/apisix-helm-chart/pull/646#issuecomment-1773108304
Awesome. I was struggling with this issue for half a day today without noticing there is an open PR already. Could this be also applied to the `dev` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin_metadata_cm path [apisix-helm-chart]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot merged PR #646:
URL: https://github.com/apache/apisix-helm-chart/pull/646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin_metadata_cm path [apisix-helm-chart]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on PR #646:
URL: https://github.com/apache/apisix-helm-chart/pull/646#issuecomment-1773113434
> Awesome. I was struggling with this issue for half a day today without noticing there is an open PR already. Could this be also applied to the `dev` branch?
Yes, welcome to create a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin_metadata_cm path [apisix-helm-chart]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on PR #646:
URL: https://github.com/apache/apisix-helm-chart/pull/646#issuecomment-1773149543
> EDIT: nvm, we just need to bump the ingress controller chart version when it is released. No need to duplicate the code.
Yes, you are right.I make a mistask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org