You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 02:50:43 UTC
[GitHub] [doris] englefly opened a new pull request, #15225: [enhance](planner)add session var: COMPACT_EQUAL_TO_IN_PREDICATE_COUNT
englefly opened a new pull request, #15225:
URL: https://github.com/apache/doris/pull/15225
# Proposed changes
in previous pr, we compact equals like "a=1 or a=2 or a = 3 " in to "a in (1, 2, 3)"
this pr set a lower bound for the number of equals COMPACT_EQUAL_TO_IN_PREDICATE_COUNT
for regression test, if we need stable output of explain string, set COMPACT_EQUAL_TO_IN_PREDICATE_COUNT to a large number to avoid compact rule.
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15225: [opt](planner) add session var: COMPACT_EQUAL_TO_IN_PREDICATE_THRESHOLD
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15225:
URL: https://github.com/apache/doris/pull/15225#issuecomment-1361295374
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15225: [enhance](planner)add session var: COMPACT_EQUAL_TO_IN_PREDICATE_COUNT
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15225:
URL: https://github.com/apache/doris/pull/15225#issuecomment-1360830627
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.56 seconds
load time: 634 seconds
storage size: 17123705228 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221221040910_clickbench_pr_65974.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #15225: [opt](planner) add session var: COMPACT_EQUAL_TO_IN_PREDICATE_THRESHOLD
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15225:
URL: https://github.com/apache/doris/pull/15225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #15225: [enhance](planner)add session var: COMPACT_EQUAL_TO_IN_PREDICATE_COUNT
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #15225:
URL: https://github.com/apache/doris/pull/15225#discussion_r1053936616
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -204,6 +204,9 @@ public class SessionVariable implements Serializable, Writable {
// percentage of EXEC_MEM_LIMIT
public static final String BROADCAST_HASHTABLE_MEM_LIMIT_PERCENTAGE = "broadcast_hashtable_mem_limit_percentage";
+
+ public static final String COMPACT_EQUAL_TO_IN_PREDICATE_COUNT = "compact_equal_to_in_predicate_count";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #15225: [enhance](planner)add session var: COMPACT_EQUAL_TO_IN_PREDICATE_COUNT
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #15225:
URL: https://github.com/apache/doris/pull/15225#discussion_r1053931082
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -204,6 +204,9 @@ public class SessionVariable implements Serializable, Writable {
// percentage of EXEC_MEM_LIMIT
public static final String BROADCAST_HASHTABLE_MEM_LIMIT_PERCENTAGE = "broadcast_hashtable_mem_limit_percentage";
+
+ public static final String COMPACT_EQUAL_TO_IN_PREDICATE_COUNT = "compact_equal_to_in_predicate_count";
Review Comment:
nit:
```suggestion
public static final String COMPACT_EQUAL_TO_IN_PREDICATE_THRESHOLD = "compact_equal_to_in_predicate_threshold";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15225: [opt](planner) add session var: COMPACT_EQUAL_TO_IN_PREDICATE_THRESHOLD
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15225:
URL: https://github.com/apache/doris/pull/15225#issuecomment-1361295337
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org