You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ji...@apache.org on 2019/03/07 00:05:35 UTC
[incubator-pinot] branch master updated: [TE] detection - add
default values for duration filter (#3917)
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new db89922 [TE] detection - add default values for duration filter (#3917)
db89922 is described below
commit db899226b63e7ac07b98fdf3de121b50f07ff56f
Author: Jihao Zhang <ji...@linkedin.com>
AuthorDate: Wed Mar 6 16:05:28 2019 -0800
[TE] detection - add default values for duration filter (#3917)
---
.../thirdeye/detection/spec/DurationAnomalyFilterSpec.java | 4 ++--
.../detection/components/DurationAnomalyFilterTest.java | 12 ++++++++++++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/DurationAnomalyFilterSpec.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/DurationAnomalyFilterSpec.java
index 8fb0122..acf676b 100644
--- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/DurationAnomalyFilterSpec.java
+++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spec/DurationAnomalyFilterSpec.java
@@ -21,8 +21,8 @@
package org.apache.pinot.thirdeye.detection.spec;
public class DurationAnomalyFilterSpec extends AbstractSpec {
- private String minDuration;
- private String maxDuration;
+ private String minDuration = "PT0S"; // default value 0 seconds
+ private String maxDuration = "P365D"; // default value 1 year
public String getMinDuration() {
return minDuration;
diff --git a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/components/DurationAnomalyFilterTest.java b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/components/DurationAnomalyFilterTest.java
index d64041b..2b362c3 100644
--- a/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/components/DurationAnomalyFilterTest.java
+++ b/thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/detection/components/DurationAnomalyFilterTest.java
@@ -43,4 +43,16 @@ public class DurationAnomalyFilterTest {
Assert.assertEquals(anomalyFilter.isQualified(makeAnomaly(1547164800000L, 1547175600000L)), true);
Assert.assertEquals(anomalyFilter.isQualified(makeAnomaly(1547164800000L, 1547179200000L)), false);
}
+
+ @Test
+ public void testDefaultQualified() {
+ AnomalyFilter anomalyFilter = new DurationAnomalyFilter();
+ DurationAnomalyFilterSpec spec = new DurationAnomalyFilterSpec();
+ anomalyFilter.init(spec, new DefaultInputDataFetcher(new MockDataProvider(), -1));
+ Assert.assertEquals(anomalyFilter.isQualified(makeAnomaly(1547164800000L, 1547168400000L)), true);
+ Assert.assertEquals(anomalyFilter.isQualified(makeAnomaly(1547164800000L, 1547172000000L)), true);
+ Assert.assertEquals(anomalyFilter.isQualified(makeAnomaly(1547164800000L, 1547175600000L)), true);
+ Assert.assertEquals(anomalyFilter.isQualified(makeAnomaly(1547164800000L, 1547179200000L)), true);
+ }
+
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org