You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/01 02:39:15 UTC

[GitHub] [spark] LuciferYang commented on a change in pull request #33852: [SPARK-36602][COER][SQL] Clean up redundant asInstanceOf casts

LuciferYang commented on a change in pull request #33852:
URL: https://github.com/apache/spark/pull/33852#discussion_r699801028



##########
File path: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
##########
@@ -165,7 +165,7 @@ private[r] class RBackendHandler(server: RBackend)
 
         // Write status bit
         writeInt(dos, 0)
-        writeObject(dos, ret.asInstanceOf[AnyRef], server.jvmObjectTracker)

Review comment:
       @HyukjinKwon Manual test build/mvn clean install -Phadoop-3.2 -Phive-2.3 -Phadoop-cloud -Pmesos -Pyarn -Pkinesis-asl -Phive-thriftserver -Pspark-ganglia-lgpl -Pkubernetes -Phive -Pscala-2.13 and all test passed.
   
   But `org.apache.spark.SparkContextSuite` sometimes fails, I need to investigate further




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org