You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2018/12/12 13:18:00 UTC

[jira] [Comment Edited] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

    [ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711084#comment-16711084 ] 

Jacques Le Roux edited comment on OFBIZ-5157 at 12/12/18 1:17 PM:
------------------------------------------------------------------

Thanks Benjamin,

I had really hard time to reproduce. At one moment I thought it could be due to a side effect of my recent changes with the autologin cookie (eg OFBIZ-10666). Note: those cookies stay for one year or until you logout or use the "Not you" link in the header. Even after manually clearing the cookie in the browser I could not reproduce.

But my error was that I did no close my browser, FF in my case. All browsers need you to close to really delete expired cookies. BTW here is [some humour about that|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860].

But FF is snarky because [it does not delete expired cookies immediately even if you close FF|https://support.mozilla.org/fr/questions/983361]. So when you quickly look at them in the browser they are still there. So I tried with IE, Chrome and could still not reproduce (forgot to close the browsers again). I finally remembered the funny story from Onion, et voilĂ , pfew :)









was (Author: jacques.le.roux):
Thanks Benjamin,

I had really hard time to reproduce. At one moment I thought it could be due to a side effect of my recent changes with the autologin cookie (eg OFBIZ-10666). Note: those cookies stay for one year or until you logout or use the "Not you" link in the header. Even after manually clearing the cookie in the browser I could not reproduce. 

But my error was that I did no close my browser, FF in my case. All browsers need you to close to really delete expired cookies. BTW here is some humour about that|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860].

But FF is snarky because [it does not delete expired cookies immediately even if you close FF|https://support.mozilla.org/fr/questions/983361]. So when you quickly look at them in the browser they are still there. So I tried with IE, Chrome and could still not reproduce (forgot to close the browsers again). I finally remembered the funny story from Onion, et voilĂ , pfew :)








> Error on createShoppingListItem when adding item to cart as anonymous
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-5157
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5157
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release Branch 17.12
>            Reporter: Mirko Vogelsmeier
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Release Branch 12.04, 17.12.01, 16.11.06
>
>         Attachments: OFBIZ-5157-CodeCleanup.patch, OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following security error occures:
> {code}
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [     UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en) created in 0.031s with 4 properties
>      [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [    TransactionUtil.java:379:WARN ]
>      [java] ---- exception report ----------------------------------------------------------
>      [java] [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening:
>      [java] Exception: java.lang.Exception
>      [java] Message: Error in simple-method [Create a ShoppingList Item [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
>      [java] ---- stack trace ---------------------------------------------------------------
>      [java] java.lang.Exception: Error in simple-method [Create a ShoppingList Item [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
>      [java] org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
>      [java] org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
>      [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
>      [java] org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
>      [java] org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
>      [java] org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>      [java] org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>      [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
>      [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
>      [java] org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
>      [java] org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
>      [java] org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
>      [java] org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
>      [java] org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
>      [java] org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
>      [java] org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
>      [java] org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
>      [java] org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)