[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2685: [#2662] pathVarParam support special characters

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #2685:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2685#discussion_r779278240



##########
File path: foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/http/HttpUtils.java
##########
@@ -90,6 +90,9 @@ public static String uriEncodePath(String path) {
    * @return the encoded path param
    */
   public static String encodePathParam(String pathParam) {
+    if (pathParam.indexOf(';') != -1) {
+      pathParam = pathParam.substring(0, pathParam.indexOf(';'));
+    }

Review comment:
       This modification is not correct. 
   
   Suggections:
   
   1. upgread guava to 30.0-jre will fix this issue




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org