You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sysadmins@spamassassin.apache.org by "Kevin A. McGrail" <km...@apache.org> on 2017/11/16 15:54:39 UTC
Rule test installation Warnings
Just alerted to this warning. Any thoughts?
root@ethan [~]# sa-update -v --install ${REV}.tar.gz
Argument "0.70_01" isn't numeric in numeric ge (>=) at
/usr/local/share/perl5/Mail/SpamAssassin/Plugin/AskDNS.pm line 214.
Argument "0.70_01" isn't numeric in numeric ge (>=) at
/usr/local/share/perl5/Mail/SpamAssassin/Plugin/AskDNS.pm line 214.
Update was available, and was downloaded and installed successfully
Re: Rule test installation Warnings
Posted by Merijn van den Kroonenberg <me...@web2all.nl>.
> Just alerted to this warning. Any thoughts?
>
> root@ethan [~]# sa-update -v --install ${REV}.tar.gz
> Argument "0.70_01" isn't numeric in numeric ge (>=) at
> /usr/local/share/perl5/Mail/SpamAssassin/Plugin/AskDNS.pm line 214.
AskDNS.pm line 214:
$txtdata_can_provide_a_list = Net::DNS->VERSION >= 0.69;
> Argument "0.70_01" isn't numeric in numeric ge (>=) at
Maybe its some kind of patched version, bacause 0.70_01 is not a version
(of Net::DNS) i can find on CPAN. The version is supposed to be numeric or
at least convertable to numeric. Obviously "0.70_01" is not, because of
the underscore.
so I guess $txtdata_can_provide_a_list will be set to false. Don't know
what it does, might just be less efficient or it might break something
when fetching txt records. But since he installed the update successfully
i guess its not too critical.
Mail::SpamAssassin::Plugin::AskDNS could be changed to strip anything away
from the version which is not [\d\.]+ before doing the comparison.
> /usr/local/share/perl5/Mail/SpamAssassin/Plugin/AskDNS.pm line 214.
> Update was available, and was downloaded and installed successfully
>
>
>
Re: Rule test installation Warnings (bug 7095)
Posted by Merijn van den Kroonenberg <me...@web2all.nl>.
> Perhaps this is relevant/helpful:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766718
Ah yes, very helpful, it also mentions:
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7095
Which concludes its a debian bug and not an SA issue, because debian
included a pre-release.
But I would say, for sake of SA robustness it would be better to apply the
suggested fix as mentioned in the debian bug report:
$txtdata_can_provide_a_list = version->parse(Net::DNS->VERSION) >=
version->parse('0.69');
So the sa-update does not break if anyone, for any reason needs to use a
pre-release version of NET::DNS
>
> On Thu, 16 Nov 2017, Merijn van den Kroonenberg wrote:
>
>>> On 11/16/2017 11:23 AM, shanew@shanew.net wrote:
>>>> Is there a version that has "0.70_01" specified?
>>
>> Actually it looks like developer versions have underscores in the
>> version
>> number
>>
>> lates dev version of NET:DNS:
>> $VERSION = '1.12_03';
>>
>> So I guess the patch
>> version->parse(Net::DNS->VERSION) >= version->parse('0.69');
>> is probably the way to go.
>>
>> maybe its already in latest SA branch, didn't check yet.
>>
>>>
>>> Yeah I think you and Merijn are right. I've asked.
>>>
>>> Regards,
>>> KAM
>>>
>>>
>>
>>
>
> --
> Public key #7BBC68D9 at | Shane Williams
> http://pgp.mit.edu/ | System Admin - UT CompSci
> =----------------------------------+-------------------------------
> All syllogisms contain three lines | shanew@shanew.net
> Therefore this is not a syllogism | www.ischool.utexas.edu/~shanew
Re: Rule test installation Warnings
Posted by sh...@shanew.net.
Perhaps this is relevant/helpful:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766718
On Thu, 16 Nov 2017, Merijn van den Kroonenberg wrote:
>> On 11/16/2017 11:23 AM, shanew@shanew.net wrote:
>>> Is there a version that has "0.70_01" specified?
>
> Actually it looks like developer versions have underscores in the version
> number
>
> lates dev version of NET:DNS:
> $VERSION = '1.12_03';
>
> So I guess the patch
> version->parse(Net::DNS->VERSION) >= version->parse('0.69');
> is probably the way to go.
>
> maybe its already in latest SA branch, didn't check yet.
>
>>
>> Yeah I think you and Merijn are right. I've asked.
>>
>> Regards,
>> KAM
>>
>>
>
>
--
Public key #7BBC68D9 at | Shane Williams
http://pgp.mit.edu/ | System Admin - UT CompSci
=----------------------------------+-------------------------------
All syllogisms contain three lines | shanew@shanew.net
Therefore this is not a syllogism | www.ischool.utexas.edu/~shanew
Re: Rule test installation Warnings
Posted by Merijn van den Kroonenberg <me...@web2all.nl>.
> On 11/16/2017 11:23 AM, shanew@shanew.net wrote:
>> Is there a version that has "0.70_01" specified?
Actually it looks like developer versions have underscores in the version
number
lates dev version of NET:DNS:
$VERSION = '1.12_03';
So I guess the patch
version->parse(Net::DNS->VERSION) >= version->parse('0.69');
is probably the way to go.
maybe its already in latest SA branch, didn't check yet.
>
> Yeah I think you and Merijn are right. I've asked.
>
> Regards,
> KAM
>
>
Re: Rule test installation Warnings
Posted by "Kevin A. McGrail" <ke...@mcgrail.com>.
On 11/16/2017 11:23 AM, shanew@shanew.net wrote:
> Is there a version that has "0.70_01" specified?
Yeah I think you and Merijn are right. I've asked.
Regards,
KAM
Re: Rule test installation Warnings
Posted by sh...@shanew.net.
I'm running 3.4.1 and I don't get that error.
Looking at my AskDNS.pm, line 214 is:
$txtdata_can_provide_a_list = Net::DNS->VERSION >= 0.69;
And checking the git repo, it looks identical in 3.4.2_pre3.
Is there a version that has "0.70_01" specified?
Interestingly, I note that on one of my systems, which I
think might have been due to some patch I applied out of bugzilla:
$txtdata_can_provide_a_list = version->parse(Net::DNS->VERSION) >= version->parse('0.69');
I wonder if that line knows what to do with the "_01" part of the
version number?
On Thu, 16 Nov 2017, Kevin A. McGrail wrote:
> Just alerted to this warning. Any thoughts?
>
> root@ethan [~]# sa-update -v --install ${REV}.tar.gz
> Argument "0.70_01" isn't numeric in numeric ge (>=) at
> /usr/local/share/perl5/Mail/SpamAssassin/Plugin/AskDNS.pm line 214.
> Argument "0.70_01" isn't numeric in numeric ge (>=) at
> /usr/local/share/perl5/Mail/SpamAssassin/Plugin/AskDNS.pm line 214.
> Update was available, and was downloaded and installed successfully
>
>
>
>
--
Public key #7BBC68D9 at | Shane Williams
http://pgp.mit.edu/ | System Admin - UT CompSci
=----------------------------------+-------------------------------
All syllogisms contain three lines | shanew@shanew.net
Therefore this is not a syllogism | www.ischool.utexas.edu/~shanew