You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Konrad Windszus (JIRA)" <ji...@apache.org> on 2011/07/21 10:18:57 UTC

[jira] [Created] (FELIX-3049) Warning that Lifecycle method deactivate has wrong number of arguments

Warning that Lifecycle method deactivate has wrong number of arguments
----------------------------------------------------------------------

                 Key: FELIX-3049
                 URL: https://issues.apache.org/jira/browse/FELIX-3049
             Project: Felix
          Issue Type: Bug
          Components: Maven SCR Plugin
            Reporter: Konrad Windszus


When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
[WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>

Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FELIX-3049) Use DS 1.1 per default

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069993#comment-13069993 ] 

Felix Meschberger commented on FELIX-3049:
------------------------------------------

I disagree because it does not match the DS spec which defaults to 1.0. There may be cases where a no-arg deactivate method might not be meant for DS...

Instead of setting the specVersion attribute you might also annotate the activate or deactivate method with the @Activate or @Deactivate annotation, resp. This will, as a side effect, cause the correct spec. version to be used in the descriptor.

> Use DS 1.1 per default
> ----------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin, SCR Annotations
>    Affects Versions: maven-scr-plugin-1.7.2, scr ant task 1.1.2
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin-1.7.4, scr ant task 1.1.4
>
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FELIX-3049) Warning that Lifecycle method deactivate has wrong number of arguments

Posted by "Konrad Windszus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068856#comment-13068856 ] 

Konrad Windszus commented on FELIX-3049:
----------------------------------------

Also the method protected void activate(final Map properties) is not accepted, although valid according to OSGi.

> Warning that Lifecycle method deactivate has wrong number of arguments
> ----------------------------------------------------------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin
>            Reporter: Konrad Windszus
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (FELIX-3049) Use DS 1.1 per default

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved FELIX-3049.
-------------------------------------

    Resolution: Won't Fix

Yes, that's right - and I agree that changing the default might even cause new
problems. And using the annotations works. So I'll close this one as won't fix.

> Use DS 1.1 per default
> ----------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin, SCR Annotations
>    Affects Versions: maven-scr-plugin-1.7.2, scr ant task 1.1.2
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin-1.7.4, scr ant task 1.1.4
>
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re:[jira] [Commented] (FELIX-3049) Use DS 1.1 per default

Posted by 梅勇 <cn...@163.com>.




At 2011-07-22 16:26:57,"Carsten Ziegeler (JIRA)" <ji...@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069440#comment-13069440 ] 
>
>Carsten Ziegeler commented on FELIX-3049:
>-----------------------------------------
>
>Yes, I stumbled across this several times as well.
>
>I agree that we should make 1.1 the default for the next version
>
>> Use DS 1.1 per default
>> ----------------------
>>
>>                 Key: FELIX-3049
>>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>>             Project: Felix
>>          Issue Type: Bug
>>          Components: Maven SCR Plugin, SCR Annotations
>>    Affects Versions: maven-scr-plugin-1.7.2, scr ant task 1.1.2
>>            Reporter: Konrad Windszus
>>            Assignee: Carsten Ziegeler
>>             Fix For: maven-scr-plugin-1.7.4, scr ant task 1.1.4
>>
>>
>> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
>> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
>> Probably this is also a problem with activate methods.
>
>--
>This message is automatically generated by JIRA.
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>        

[jira] [Commented] (FELIX-3049) Use DS 1.1 per default

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069440#comment-13069440 ] 

Carsten Ziegeler commented on FELIX-3049:
-----------------------------------------

Yes, I stumbled across this several times as well.

I agree that we should make 1.1 the default for the next version

> Use DS 1.1 per default
> ----------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin, SCR Annotations
>    Affects Versions: maven-scr-plugin-1.7.2, scr ant task 1.1.2
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin-1.7.4, scr ant task 1.1.4
>
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FELIX-3049) Warning that Lifecycle method deactivate has wrong number of arguments

Posted by "Konrad Windszus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068864#comment-13068864 ] 

Konrad Windszus commented on FELIX-3049:
----------------------------------------

Sorry my fault, when setting the specVersion to 1.1 it is working. Maybe this should version should be the default by now.

> Warning that Lifecycle method deactivate has wrong number of arguments
> ----------------------------------------------------------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin
>            Reporter: Konrad Windszus
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (FELIX-3049) Use DS 1.1 per default

Posted by "Carsten Ziegeler (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed FELIX-3049.
-----------------------------------

    
> Use DS 1.1 per default
> ----------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin, SCR Annotations
>    Affects Versions: maven-scr-plugin-1.7.2, scr ant task 1.1.2
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin-1.7.4, scr ant task 1.1.4
>
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FELIX-3049) Use DS 1.1 per default

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler updated FELIX-3049:
------------------------------------

          Component/s: SCR Annotations
    Affects Version/s: scr ant task 1.1.2
                       maven-scr-plugin-1.7.2
        Fix Version/s: scr ant task 1.1.4
                       maven-scr-plugin-1.7.4
             Assignee: Carsten Ziegeler
              Summary: Use DS 1.1 per default  (was: Warning that Lifecycle method deactivate has wrong number of arguments)

> Use DS 1.1 per default
> ----------------------
>
>                 Key: FELIX-3049
>                 URL: https://issues.apache.org/jira/browse/FELIX-3049
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin, SCR Annotations
>    Affects Versions: maven-scr-plugin-1.7.2, scr ant task 1.1.2
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin-1.7.4, scr ant task 1.1.4
>
>
> When you have a deactivate method with no arguments, which is valid, according to the OSGi spec (R4 Comp. 112.5.14) I will get the warning:
> [WARNING] @Component: Lifecycle method deactivate has wrong number of arguments at Java annotations in <Classfile:Linenumber>
> Probably this is also a problem with activate methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira