You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/21 07:53:32 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #21678: Refactor DistSQL VARIABLE
Pace2Car opened a new pull request, #21678:
URL: https://github.com/apache/shardingsphere/pull/21678
Fixes #21669 .
Changes proposed in this pull request:
- Change keyword SHOW ALL VARIABLES -> SHOW DIST VARIABLES
- Change keyword SHOW VARIABLE variableName -> SHOW DIST VARIABLE WHERE name = xx
- Change keyword SET VARIABLE xx = yy -> SET DIST VARIABLE xx = yy
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #21678: Refactor DistSQL VARIABLE
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #21678:
URL: https://github.com/apache/shardingsphere/pull/21678#discussion_r1001492933
##########
test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/queryable/ShowAllVariablesStatementAssert.java:
##########
@@ -35,7 +35,7 @@ public final class ShowAllVariablesStatementAssert {
* @param actual actual show all variables statement
* @param expected expected show all variables statement test case
Review Comment:
If you change the class name, please update comment, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #21678: Refactor DistSQL VARIABLE
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #21678:
URL: https://github.com/apache/shardingsphere/pull/21678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #21678: Refactor DistSQL VARIABLE
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #21678:
URL: https://github.com/apache/shardingsphere/pull/21678#discussion_r1001491921
##########
docs/document/content/user-manual/shardingsphere-proxy/migration/usage.cn.md:
##########
@@ -27,8 +27,8 @@ max_connections=600
执行以下命令，确认是否有开启 binlog：
```
-show variables like '%log_bin%';
-show variables like '%binlog%';
+show dist variables like '%log_bin%';
Review Comment:
`show variables` is not a DistSQL, please do not modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org