You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/14 15:29:16 UTC

[GitHub] [camel-k] httpsOmkar opened a new pull request #2507: Added minikube to run in one command

httpsOmkar opened a new pull request #2507:
URL: https://github.com/apache/camel-k/pull/2507


   <!-- Description -->
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on pull request #2507: Added minikube to run in one command

Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #2507:
URL: https://github.com/apache/camel-k/pull/2507#issuecomment-889632787


   Thanks. Fixed 279b1be53026735fd88a0dd8dafb1b226f6da317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi closed pull request #2507: Added minikube to run in one command

Posted by GitBox <gi...@apache.org>.
tadayosi closed pull request #2507:
URL: https://github.com/apache/camel-k/pull/2507


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on a change in pull request #2507: Added minikube to run in one command

Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #2507:
URL: https://github.com/apache/camel-k/pull/2507#discussion_r670117792



##########
File path: docs/modules/ROOT/pages/installation/minikube.adoc
##########
@@ -6,14 +6,8 @@ Follow the instructions in the https://github.com/kubernetes/minikube#installati
 
 Start a new instance of Minikube using the command:
 
-```
-minikube start
-```
-
-After the startup process is completed, you need to **enable the `registry` addon**:

Review comment:
       Putting it in one command is great, but it's better to preserve the instruction that the `registry` addon is necessary. Maybe we can pushing this sentence one-line above?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi commented on a change in pull request #2507: Added minikube to run in one command

Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #2507:
URL: https://github.com/apache/camel-k/pull/2507#discussion_r671983332



##########
File path: docs/modules/ROOT/pages/installation/minikube.adoc
##########
@@ -4,16 +4,10 @@
 You can run Camel K integrations on plain Kubernetes using the Minikube cluster creation tool.
 Follow the instructions in the https://github.com/kubernetes/minikube#installation[official doc] for the installation.
 
-Start a new instance of Minikube using the command:
+Start a new instance of Minikube with `registry` addon using the command:

Review comment:
       Not sure, it seems ok but it doesn't yet say the registry addon is necessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org