[jira] [Comment Edited] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

["Peter Bacsko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762595#comment-16762595 ] 

Peter Bacsko edited comment on YARN-9266 at 2/7/19 11:54 AM:
-------------------------------------------------------------

Patch v2 - removed {{aliasMap}}, fixed a lot of checkstyle issues.


was (Author: pbacsko):
Patvh v2 - removed {{aliasMap}}, fixed a lot of checkstyle issues.

> Various fixes are needed in IntelFpgaOpenclPlugin
> -------------------------------------------------
>
>                 Key: YARN-9266
>                 URL: https://issues.apache.org/jira/browse/YARN-9266
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9266-001.patch, YARN-9266-002.patch
>
>
> Problems identified in this class:
>  * {{InnerShellExecutor}} ignores the timeout parameter
>  * {{configureIP()}} uses printStackTrace() instead of logging
>  * {{configureIP()}} does not log the output of aocl if the exit code != 0
>  * {{parseDiagnoseInfo()}} is too heavyweight – it should be in its own class for better testability
>  * {{downloadIP()}} uses {{contains()}} for file name check – this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches)
>  * method name {{downloadIP()}} is misleading – it actually tries to finds the file. Everything is downloaded (localized) at this point.
>  * {{@VisibleForTesting}} methods should be package private
>  * {{aliasMap}} is not needed - store the acl number in the {{FpgaDevice}} class



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org