[GitHub] attilapiros commented on a change in pull request #22578: [SPARK-25564][CORE] Add output bytes metrics for each Executor

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #22578: [SPARK-25564][CORE] Add output bytes metrics for each Executor
URL: https://github.com/apache/spark/pull/22578#discussion_r261340320
 
 

 ##########
 File path: core/src/test/resources/HistoryServerExpectations/executor_list_json_expectation.json
 ##########
 @@ -14,6 +14,7 @@
   "totalDuration" : 8820,
   "totalGCTime" : 352,
   "totalInputBytes" : 28000288,
+  "totalOutputBytes" : 0,
 
 Review comment:
   It would be nice to see at least one example where the totalOutputByte is nonzero. For example you could modify an existing spark events in `core/src/test/resources/spark-events` as a new test test could be overkill for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org