You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/04/02 23:31:12 UTC
[jira] Created: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
integrate cppunit testing as part of hudson patch process.
----------------------------------------------------------
Key: ZOOKEEPER-361
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
Project: Zookeeper
Issue Type: New Feature
Affects Versions: 3.1.1, 3.1.0, 3.0.1, 3.0.0
Reporter: Mahadev konar
Assignee: Giridharan Kesavan
we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695259#action_12695259 ]
Giridharan Kesavan commented on ZOOKEEPER-361:
----------------------------------------------
you can test this out by doing "ant call-test-cppunit" - this would create the makefiles and executes the tests.
tnx!
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Attachments: zk-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-361:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks giri..
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698315#action_12698315 ]
Giridharan Kesavan commented on ZOOKEEPER-361:
----------------------------------------------
thanks Mahadev for looking into this patch and fixing it.
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-361:
------------------------------------
Component/s: build
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-361:
------------------------------------
Fix Version/s: 3.2.0
Status: Patch Available (was: Open)
giri can you verify this works?
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.1.1, 3.1.0, 3.0.1, 3.0.0
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698649#action_12698649 ]
Giridharan Kesavan commented on ZOOKEEPER-361:
----------------------------------------------
+1 Patch works on vesta.
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695493#action_12695493 ]
Mahadev konar commented on ZOOKEEPER-361:
-----------------------------------------
i dont have access to vesta... can you grant me access, so that I can run the tests on the hudson machines?
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Attachments: zk-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699381#action_12699381 ]
Hudson commented on ZOOKEEPER-361:
----------------------------------
Integrated in ZooKeeper-trunk #281 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/281/])
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697967#action_12697967 ]
Hadoop QA commented on ZOOKEEPER-361:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405181/zookeeper-361.patch
against trunk revision 763973.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/24/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/24/console
This message is automatically generated.
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-361:
-----------------------------------------
Attachment: zk-361.patch
Here is the patch;
I see a failure here, though this patch makes changes only to the build.xml.
[exec] /home/gkesavan/zk-trunk/src/c/tests/TestZookeeperInit.cc:93: Assertion: equality assertion failed [Expected: 1, Actual : 2]
[exec] Failures !!!
[exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0
[exec] make: *** [run-check] Error 1
[exec] Result: 2
Mahadev,
Could you take a look , this failure happens only on vesta and not in my local box.
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Attachments: zk-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-361) integrate cppunit testing as part
of hudson patch process.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-361:
------------------------------------
Attachment: zookeeper-361.patch
this patch should fix the issue. I just tested it on vesta. thanks for granting me access.
- the problem was with the machine being ipv6 enabled and the localhost lookup returning multuple addresses. I changed the client address to 127.0.0.1
- the second problem is the script using /tmp/zkdata, I made it to use build/tmp for all the temporary logs/zookeeper database. this one took me a while since I thought the problem was with the c tests wherein a node was showing up as existing (which should not have existed). The reason was that I wasnt deleting the old zookeeper database in the script, so it was using the old database in which the node existed :).
> integrate cppunit testing as part of hudson patch process.
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-361
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361
> Project: Zookeeper
> Issue Type: New Feature
> Components: build
> Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Giridharan Kesavan
> Attachments: zk-361.patch, zookeeper-361.patch
>
>
> we need to test the c tests as part of our hudson patch testing process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.