You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/30 14:50:58 UTC
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4593: [BugFix] Fix wrong H2 column type
kezhenxu94 commented on a change in pull request #4593: [BugFix] Fix wrong H2 column type
URL: https://github.com/apache/skywalking/pull/4593#discussion_r400254005
##########
File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2TableInstaller.java
##########
@@ -92,7 +92,7 @@ protected String getColumnType(ModelColumn column) {
} else if (String.class.equals(type)) {
return "VARCHAR(" + column.getLength() + ")";
} else if (IntKeyLongValueHashMap.class.equals(type)) {
- return "MEDIUMTEXT";
+ return "VARCHAR(20000)";
Review comment:
> Why change this?
<img width="669" alt="image" src="https://user-images.githubusercontent.com/15965696/77926626-e93fdb00-72d8-11ea-9b13-8b995672f956.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services