You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2019/10/25 15:55:54 UTC
[wicket] branch wicket-7.x updated (dadbc2a -> d9e39f9)
This is an automated email from the ASF dual-hosted git repository.
adelbene pushed a change to branch wicket-7.x
in repository https://gitbox.apache.org/repos/asf/wicket.git.
from dadbc2a WICKET-6708 optimization
new f7bbd0f WICKET-6708 fix to avoid form submition break if request method is in uppercase form (ie: GET, POST)
new d3b3829 WICKET-6708 Made lowercase conversion local insentive, as did for WICKET-6614
new ab3c978 Code adjusted for JUnit 4
new d9e39f9 Code formatting improvements
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../wicket/markup/html/form/FormComponent.java | 2 +-
.../wicket/markup/html/form/FormComponentTest.java | 26 ++++++++++++++++++----
2 files changed, 23 insertions(+), 5 deletions(-)
[wicket] 02/04: WICKET-6708 Made lowercase conversion local
insentive, as did for WICKET-6614
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adelbene pushed a commit to branch wicket-7.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit d3b3829732b2e359775333a99e342b1f0e4a3aed
Author: Andrea Del Bene <an...@gmail.com>
AuthorDate: Fri Oct 25 12:01:07 2019 +0200
WICKET-6708 Made lowercase conversion local insentive, as did for WICKET-6614
---
.../src/main/java/org/apache/wicket/markup/html/form/FormComponent.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
index 0a21bea..c722c24 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
@@ -812,7 +812,7 @@ public abstract class FormComponent<T> extends LabeledWebMarkupContainer impleme
}
final IRequestParameters parameters;
- switch (method.toLowerCase())
+ switch (method.toLowerCase(Locale.ROOT))
{
case Form.METHOD_POST:
parameters = request.getPostParameters();
[wicket] 01/04: WICKET-6708 fix to avoid form submition break if
request method is in uppercase form (ie: GET, POST)
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adelbene pushed a commit to branch wicket-7.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit f7bbd0f460699385eaa654e09b939fceaea7f61c
Author: Andrea Del Bene <an...@gmail.com>
AuthorDate: Fri Oct 25 11:45:41 2019 +0200
WICKET-6708 fix to avoid form submition break if request method is in uppercase form (ie: GET, POST)
---
.../org/apache/wicket/markup/html/form/FormComponent.java | 2 +-
.../apache/wicket/markup/html/form/FormComponentTest.java | 15 +++++++++++++++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
index fb8a06f..0a21bea 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
@@ -812,7 +812,7 @@ public abstract class FormComponent<T> extends LabeledWebMarkupContainer impleme
}
final IRequestParameters parameters;
- switch (method)
+ switch (method.toLowerCase())
{
case Form.METHOD_POST:
parameters = request.getPostParameters();
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
index 3a84940..87e3399 100644
--- a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
@@ -87,6 +87,21 @@ public class FormComponentTest extends WicketTestCase
assertTrue(validator.called);
}
+
+ @Test
+ void upperCasePostSubmit()
+ {
+ tester.startPage(TestPage1.class);
+ FormTester formTester = tester.newFormTester("form");
+
+ formTester.setValue("field1", "foo");
+ formTester.setValue("field2", "bar");
+ tester.getRequest().setMethod("POST");
+ formTester.submit();
+
+ assertEquals("foo", formTester.getTextComponentValue("field1"));
+ assertEquals("bar", formTester.getTextComponentValue("field2"));
+ }
public static class TestPage1 extends WebPage implements IMarkupResourceStreamProvider
{
[wicket] 03/04: Code adjusted for JUnit 4
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adelbene pushed a commit to branch wicket-7.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit ab3c9786a89fd64210fdd5c3ca93b4202e3e3446
Author: Andrea Del Bene <an...@gmail.com>
AuthorDate: Fri Oct 25 14:55:34 2019 +0200
Code adjusted for JUnit 4
---
.../wicket/markup/html/form/FormComponentTest.java | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
index 87e3399..bdb75c0 100644
--- a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
@@ -16,16 +16,19 @@
*/
package org.apache.wicket.markup.html.form;
-import org.junit.Assert;
import org.apache.wicket.MarkupContainer;
import org.apache.wicket.markup.IMarkupResourceStreamProvider;
import org.apache.wicket.markup.html.WebPage;
+import org.apache.wicket.model.Model;
import org.apache.wicket.util.resource.IResourceStream;
import org.apache.wicket.util.resource.StringResourceStream;
+import org.apache.wicket.util.tester.FormTester;
import org.apache.wicket.util.tester.WicketTestCase;
import org.apache.wicket.validation.INullAcceptingValidator;
import org.apache.wicket.validation.IValidatable;
-import org.junit.Test;
+import org.junit.Assert;
+import org.junit.Test;
+
/**
*
@@ -89,7 +92,7 @@ public class FormComponentTest extends WicketTestCase
}
@Test
- void upperCasePostSubmit()
+ public void upperCasePostSubmit()
{
tester.startPage(TestPage1.class);
FormTester formTester = tester.newFormTester("form");
@@ -99,9 +102,9 @@ public class FormComponentTest extends WicketTestCase
tester.getRequest().setMethod("POST");
formTester.submit();
- assertEquals("foo", formTester.getTextComponentValue("field1"));
- assertEquals("bar", formTester.getTextComponentValue("field2"));
- }
+ assertEquals("foo", formTester.getTextComponentValue("field1"));
+ assertEquals("bar", formTester.getTextComponentValue("field2"));
+ }
public static class TestPage1 extends WebPage implements IMarkupResourceStreamProvider
{
@@ -111,8 +114,8 @@ public class FormComponentTest extends WicketTestCase
{
Form form = new Form("form");
add(form);
- form.add(field1 = new TextField("field1"));
- form.add(field2 = new TextField("field2"));
+ form.add(field1 = new TextField("field1", Model.of("")));
+ form.add(field2 = new TextField("field2", Model.of("")));
}
@Override
[wicket] 04/04: Code formatting improvements
Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
adelbene pushed a commit to branch wicket-7.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit d9e39f91b78d9b101a1227b8e1a8132d4cdd6805
Author: Andrea Del Bene <an...@gmail.com>
AuthorDate: Fri Oct 25 15:01:30 2019 +0200
Code formatting improvements
---
.../java/org/apache/wicket/markup/html/form/FormComponentTest.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
index bdb75c0..e5ea1b4 100644
--- a/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormComponentTest.java
@@ -102,9 +102,9 @@ public class FormComponentTest extends WicketTestCase
tester.getRequest().setMethod("POST");
formTester.submit();
- assertEquals("foo", formTester.getTextComponentValue("field1"));
- assertEquals("bar", formTester.getTextComponentValue("field2"));
- }
+ assertEquals("foo", formTester.getTextComponentValue("field1"));
+ assertEquals("bar", formTester.getTextComponentValue("field2"));
+ }
public static class TestPage1 extends WebPage implements IMarkupResourceStreamProvider
{