[jira] Commented: (DERBY-779) Add tests from derbylang to derbynetclientmats suite

["Daniel John Debrunner (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-779?page=comments#action_12361090 ] 

Daniel John Debrunner commented on DERBY-779:
---------------------------------------------

I wonder if we had cleaner separation of tests between lang and jdbcapi then it would be clearer that only jdbcpai tests need to run with the both the network server and embedded. Then no lang tests (or maybe a few) would be run under the network server. This is because lang (especially .sql ones) tests are testing the SQL language and not the JDBC api. Pretty much all the .sql tests will just test executing a statement that returns an update count or one that returns a result set and then ij calling getString on it. Not really much of a work-out for the network server and client. And it doesn't matter to the network server if that ResultSet was a result of a simple select or a 10 way join.

Lang tests like cursor, holdCursor, updateableResultSet , outparams are really tests of the jdbcapi and maybe should be in jdbcapi package.

Then there are tests like procedure where it's testing the jdbcapi (CallableStatement, multiple result sets) and the SQL layer (procedure calling, procedure SQL control), not sure what should be done there.

> Add tests from derbylang to derbynetclientmats suite
> ----------------------------------------------------
>
>          Key: DERBY-779
>          URL: http://issues.apache.org/jira/browse/DERBY-779
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>     Priority: Minor

>
> I ran derbyall by adding derbylang suite to derbynetclientmats. Most of the tests needed new masters with client driver. I found that test coverage did not increase much whereas time to run derbyall increased by ~75 minutes. Here is the increase in test coverage from EMMA:
> org.apache.derby.client.am : 1% method and block coverage
> org.apache.derby.client.net : 2% block and line coverage
> org.apache.derby.jdbc.ClientDriver.java : 4% block and 2% line coverage
> 	
> Instead of adding the whole suite, I think I will look at classes/methods which are not covered and see which tests can be added from derbylang to improve test coverage.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira