You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/08/19 03:20:30 UTC

Review Request 24833: qualified tablenames usage does not work with several alter-table commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24833/
-----------------------------------------------------------

Review request for hive and Thejas Nair.


Bugs: HIVE-7681
    https://issues.apache.org/jira/browse/HIVE-7681


Repository: hive-git


Description
-------

Changes were made in HIVE-4064 for use of qualified table names in more types of queries. But several alter table commands don't work with qualified 
- alter table default.tmpfoo set tblproperties ("bar" = "bar value")
- ALTER TABLE default.kv_rename_test CHANGE a a STRING
- add,drop partition
- alter index rebuild


Diffs
-----

  hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ff0f210 
  hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java 4d338b5 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestSemanticAnalysis.java 1e25ed3 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java ae89182 
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java 1e01001 
  ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 27e251c 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java e7434a3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 60d490f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f31a409 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g a76cad7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 8527239 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7a71ec7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 3dfce99 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 20d863b 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 67be666 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 29ae4a0 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 45404fe 
  ql/src/test/queries/clientpositive/add_part_exist.q d176661 
  ql/src/test/queries/clientpositive/alter1.q 312a017 
  ql/src/test/queries/clientpositive/alter_char1.q d391138 
  ql/src/test/queries/clientpositive/alter_index.q 2aa13da 
  ql/src/test/queries/clientpositive/alter_partition_coltype.q 115eaf9 
  ql/src/test/queries/clientpositive/alter_skewed_table.q 216bbb5 
  ql/src/test/queries/clientpositive/alter_varchar1.q 6f644a0 
  ql/src/test/queries/clientpositive/alter_view_as_select.q dcab3ca 
  ql/src/test/queries/clientpositive/alter_view_rename.q 68cf9d6 
  ql/src/test/queries/clientpositive/archive_multi.q 2c1a6d8 
  ql/src/test/queries/clientpositive/create_or_replace_view.q a8f59b7 
  ql/src/test/queries/clientpositive/drop_multi_partitions.q 14e2356 
  ql/src/test/queries/clientpositive/exchange_partition.q 4be6e3f 
  ql/src/test/queries/clientpositive/index_auto_empty.q 41f4a40 
  ql/src/test/queries/clientpositive/touch.q 8a661ef 
  ql/src/test/queries/clientpositive/unset_table_view_property.q f838cd1 
  ql/src/test/results/clientpositive/add_part_exist.q.out 4c22d6a 
  ql/src/test/results/clientpositive/alter1.q.out 1cfaf75 
  ql/src/test/results/clientpositive/alter_char1.q.out 017da60 
  ql/src/test/results/clientpositive/alter_index.q.out 2093e2f 
  ql/src/test/results/clientpositive/alter_partition_coltype.q.out 25eb48c 
  ql/src/test/results/clientpositive/alter_skewed_table.q.out e6bfc5a 
  ql/src/test/results/clientpositive/alter_varchar1.q.out e74a7ed 
  ql/src/test/results/clientpositive/alter_view_as_select.q.out 53a6b37 
  ql/src/test/results/clientpositive/alter_view_rename.q.out 0f3dd14 
  ql/src/test/results/clientpositive/archive_multi.q.out 7e84def 
  ql/src/test/results/clientpositive/create_or_replace_view.q.out 52ff417 
  ql/src/test/results/clientpositive/drop_multi_partitions.q.out 58a472c 
  ql/src/test/results/clientpositive/exchange_partition.q.out 381a9fd 
  ql/src/test/results/clientpositive/index_auto_empty.q.out 6a1a6c5 
  ql/src/test/results/clientpositive/touch.q.out 7ea3807 
  ql/src/test/results/clientpositive/unset_table_view_property.q.out 8cf6686 

Diff: https://reviews.apache.org/r/24833/diff/


Testing
-------


Thanks,

Navis Ryu


Re: Review Request 24833: qualified tablenames usage does not work with several alter-table commands

Posted by Navis Ryu <na...@nexr.com>.

> On Aug. 22, 2014, 2:24 a.m., Thejas Nair wrote:
> > hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java, line 185
> > <https://reviews.apache.org/r/24833/diff/1/?file=664042#file664042line185>
> >
> >     What does this additional switch-case statement do ? Looks like it does not have any impact, it does not matter what the child token is. I think we can get rid of it.

There was no TOK_ALTERVIEW but added in this patch for simplicity of grammar. TOK_ALTERVIEW_* are now child of TOK_ALTERVIEW. This is for that.


> On Aug. 22, 2014, 2:24 a.m., Thejas Nair wrote:
> > hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java, line 221
> > <https://reviews.apache.org/r/24833/diff/1/?file=664042#file664042line221>
> >
> >     same with this switch-case

Same as above


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24833/#review51243
-----------------------------------------------------------


On Aug. 19, 2014, 1:20 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24833/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 1:20 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-7681
>     https://issues.apache.org/jira/browse/HIVE-7681
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changes were made in HIVE-4064 for use of qualified table names in more types of queries. But several alter table commands don't work with qualified 
> - alter table default.tmpfoo set tblproperties ("bar" = "bar value")
> - ALTER TABLE default.kv_rename_test CHANGE a a STRING
> - add,drop partition
> - alter index rebuild
> 
> 
> Diffs
> -----
> 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ff0f210 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java 4d338b5 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestSemanticAnalysis.java 1e25ed3 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java ae89182 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java 1e01001 
>   ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 27e251c 
>   ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java e7434a3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 60d490f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f31a409 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g a76cad7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 8527239 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7a71ec7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 3dfce99 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 20d863b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 67be666 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 29ae4a0 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 45404fe 
>   ql/src/test/queries/clientpositive/add_part_exist.q d176661 
>   ql/src/test/queries/clientpositive/alter1.q 312a017 
>   ql/src/test/queries/clientpositive/alter_char1.q d391138 
>   ql/src/test/queries/clientpositive/alter_index.q 2aa13da 
>   ql/src/test/queries/clientpositive/alter_partition_coltype.q 115eaf9 
>   ql/src/test/queries/clientpositive/alter_skewed_table.q 216bbb5 
>   ql/src/test/queries/clientpositive/alter_varchar1.q 6f644a0 
>   ql/src/test/queries/clientpositive/alter_view_as_select.q dcab3ca 
>   ql/src/test/queries/clientpositive/alter_view_rename.q 68cf9d6 
>   ql/src/test/queries/clientpositive/archive_multi.q 2c1a6d8 
>   ql/src/test/queries/clientpositive/create_or_replace_view.q a8f59b7 
>   ql/src/test/queries/clientpositive/drop_multi_partitions.q 14e2356 
>   ql/src/test/queries/clientpositive/exchange_partition.q 4be6e3f 
>   ql/src/test/queries/clientpositive/index_auto_empty.q 41f4a40 
>   ql/src/test/queries/clientpositive/touch.q 8a661ef 
>   ql/src/test/queries/clientpositive/unset_table_view_property.q f838cd1 
>   ql/src/test/results/clientpositive/add_part_exist.q.out 4c22d6a 
>   ql/src/test/results/clientpositive/alter1.q.out 1cfaf75 
>   ql/src/test/results/clientpositive/alter_char1.q.out 017da60 
>   ql/src/test/results/clientpositive/alter_index.q.out 2093e2f 
>   ql/src/test/results/clientpositive/alter_partition_coltype.q.out 25eb48c 
>   ql/src/test/results/clientpositive/alter_skewed_table.q.out e6bfc5a 
>   ql/src/test/results/clientpositive/alter_varchar1.q.out e74a7ed 
>   ql/src/test/results/clientpositive/alter_view_as_select.q.out 53a6b37 
>   ql/src/test/results/clientpositive/alter_view_rename.q.out 0f3dd14 
>   ql/src/test/results/clientpositive/archive_multi.q.out 7e84def 
>   ql/src/test/results/clientpositive/create_or_replace_view.q.out 52ff417 
>   ql/src/test/results/clientpositive/drop_multi_partitions.q.out 58a472c 
>   ql/src/test/results/clientpositive/exchange_partition.q.out 381a9fd 
>   ql/src/test/results/clientpositive/index_auto_empty.q.out 6a1a6c5 
>   ql/src/test/results/clientpositive/touch.q.out 7ea3807 
>   ql/src/test/results/clientpositive/unset_table_view_property.q.out 8cf6686 
> 
> Diff: https://reviews.apache.org/r/24833/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Re: Review Request 24833: qualified tablenames usage does not work with several alter-table commands

Posted by Thejas Nair <th...@hortonworks.com>.

> On Aug. 22, 2014, 2:24 a.m., Thejas Nair wrote:
> > hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java, line 185
> > <https://reviews.apache.org/r/24833/diff/1/?file=664042#file664042line185>
> >
> >     What does this additional switch-case statement do ? Looks like it does not have any impact, it does not matter what the child token is. I think we can get rid of it.
> 
> Navis Ryu wrote:
>     There was no TOK_ALTERVIEW but added in this patch for simplicity of grammar. TOK_ALTERVIEW_* are now child of TOK_ALTERVIEW. This is for that.

I understand the need for using TOK_ALTERVIEW. But the check using switch case on the children seems redundant. The switch statement does not cause difference in behavior if child is one of those in case statement or not. Also it does not matter what the child is, as we just need to ensure that this is a DDL statement.


- Thejas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24833/#review51243
-----------------------------------------------------------


On Aug. 19, 2014, 1:20 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24833/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 1:20 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-7681
>     https://issues.apache.org/jira/browse/HIVE-7681
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changes were made in HIVE-4064 for use of qualified table names in more types of queries. But several alter table commands don't work with qualified 
> - alter table default.tmpfoo set tblproperties ("bar" = "bar value")
> - ALTER TABLE default.kv_rename_test CHANGE a a STRING
> - add,drop partition
> - alter index rebuild
> 
> 
> Diffs
> -----
> 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ff0f210 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java 4d338b5 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestSemanticAnalysis.java 1e25ed3 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java ae89182 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java 1e01001 
>   ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 27e251c 
>   ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java e7434a3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 60d490f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f31a409 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g a76cad7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 8527239 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7a71ec7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 3dfce99 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 20d863b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 67be666 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 29ae4a0 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 45404fe 
>   ql/src/test/queries/clientpositive/add_part_exist.q d176661 
>   ql/src/test/queries/clientpositive/alter1.q 312a017 
>   ql/src/test/queries/clientpositive/alter_char1.q d391138 
>   ql/src/test/queries/clientpositive/alter_index.q 2aa13da 
>   ql/src/test/queries/clientpositive/alter_partition_coltype.q 115eaf9 
>   ql/src/test/queries/clientpositive/alter_skewed_table.q 216bbb5 
>   ql/src/test/queries/clientpositive/alter_varchar1.q 6f644a0 
>   ql/src/test/queries/clientpositive/alter_view_as_select.q dcab3ca 
>   ql/src/test/queries/clientpositive/alter_view_rename.q 68cf9d6 
>   ql/src/test/queries/clientpositive/archive_multi.q 2c1a6d8 
>   ql/src/test/queries/clientpositive/create_or_replace_view.q a8f59b7 
>   ql/src/test/queries/clientpositive/drop_multi_partitions.q 14e2356 
>   ql/src/test/queries/clientpositive/exchange_partition.q 4be6e3f 
>   ql/src/test/queries/clientpositive/index_auto_empty.q 41f4a40 
>   ql/src/test/queries/clientpositive/touch.q 8a661ef 
>   ql/src/test/queries/clientpositive/unset_table_view_property.q f838cd1 
>   ql/src/test/results/clientpositive/add_part_exist.q.out 4c22d6a 
>   ql/src/test/results/clientpositive/alter1.q.out 1cfaf75 
>   ql/src/test/results/clientpositive/alter_char1.q.out 017da60 
>   ql/src/test/results/clientpositive/alter_index.q.out 2093e2f 
>   ql/src/test/results/clientpositive/alter_partition_coltype.q.out 25eb48c 
>   ql/src/test/results/clientpositive/alter_skewed_table.q.out e6bfc5a 
>   ql/src/test/results/clientpositive/alter_varchar1.q.out e74a7ed 
>   ql/src/test/results/clientpositive/alter_view_as_select.q.out 53a6b37 
>   ql/src/test/results/clientpositive/alter_view_rename.q.out 0f3dd14 
>   ql/src/test/results/clientpositive/archive_multi.q.out 7e84def 
>   ql/src/test/results/clientpositive/create_or_replace_view.q.out 52ff417 
>   ql/src/test/results/clientpositive/drop_multi_partitions.q.out 58a472c 
>   ql/src/test/results/clientpositive/exchange_partition.q.out 381a9fd 
>   ql/src/test/results/clientpositive/index_auto_empty.q.out 6a1a6c5 
>   ql/src/test/results/clientpositive/touch.q.out 7ea3807 
>   ql/src/test/results/clientpositive/unset_table_view_property.q.out 8cf6686 
> 
> Diff: https://reviews.apache.org/r/24833/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Re: Review Request 24833: qualified tablenames usage does not work with several alter-table commands

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24833/#review51243
-----------------------------------------------------------



hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
<https://reviews.apache.org/r/24833/#comment89333>

    What does this additional switch-case statement do ? Looks like it does not have any impact, it does not matter what the child token is. I think we can get rid of it.



hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
<https://reviews.apache.org/r/24833/#comment89334>

    same with this switch-case


- Thejas Nair


On Aug. 19, 2014, 1:20 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24833/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 1:20 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-7681
>     https://issues.apache.org/jira/browse/HIVE-7681
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changes were made in HIVE-4064 for use of qualified table names in more types of queries. But several alter table commands don't work with qualified 
> - alter table default.tmpfoo set tblproperties ("bar" = "bar value")
> - ALTER TABLE default.kv_rename_test CHANGE a a STRING
> - add,drop partition
> - alter index rebuild
> 
> 
> Diffs
> -----
> 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ff0f210 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java 4d338b5 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestSemanticAnalysis.java 1e25ed3 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateInputAccessTimeHook.java ae89182 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java 1e01001 
>   ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 27e251c 
>   ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java e7434a3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 60d490f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f31a409 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g a76cad7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 8527239 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7a71ec7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 3dfce99 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 20d863b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 67be666 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 29ae4a0 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 45404fe 
>   ql/src/test/queries/clientpositive/add_part_exist.q d176661 
>   ql/src/test/queries/clientpositive/alter1.q 312a017 
>   ql/src/test/queries/clientpositive/alter_char1.q d391138 
>   ql/src/test/queries/clientpositive/alter_index.q 2aa13da 
>   ql/src/test/queries/clientpositive/alter_partition_coltype.q 115eaf9 
>   ql/src/test/queries/clientpositive/alter_skewed_table.q 216bbb5 
>   ql/src/test/queries/clientpositive/alter_varchar1.q 6f644a0 
>   ql/src/test/queries/clientpositive/alter_view_as_select.q dcab3ca 
>   ql/src/test/queries/clientpositive/alter_view_rename.q 68cf9d6 
>   ql/src/test/queries/clientpositive/archive_multi.q 2c1a6d8 
>   ql/src/test/queries/clientpositive/create_or_replace_view.q a8f59b7 
>   ql/src/test/queries/clientpositive/drop_multi_partitions.q 14e2356 
>   ql/src/test/queries/clientpositive/exchange_partition.q 4be6e3f 
>   ql/src/test/queries/clientpositive/index_auto_empty.q 41f4a40 
>   ql/src/test/queries/clientpositive/touch.q 8a661ef 
>   ql/src/test/queries/clientpositive/unset_table_view_property.q f838cd1 
>   ql/src/test/results/clientpositive/add_part_exist.q.out 4c22d6a 
>   ql/src/test/results/clientpositive/alter1.q.out 1cfaf75 
>   ql/src/test/results/clientpositive/alter_char1.q.out 017da60 
>   ql/src/test/results/clientpositive/alter_index.q.out 2093e2f 
>   ql/src/test/results/clientpositive/alter_partition_coltype.q.out 25eb48c 
>   ql/src/test/results/clientpositive/alter_skewed_table.q.out e6bfc5a 
>   ql/src/test/results/clientpositive/alter_varchar1.q.out e74a7ed 
>   ql/src/test/results/clientpositive/alter_view_as_select.q.out 53a6b37 
>   ql/src/test/results/clientpositive/alter_view_rename.q.out 0f3dd14 
>   ql/src/test/results/clientpositive/archive_multi.q.out 7e84def 
>   ql/src/test/results/clientpositive/create_or_replace_view.q.out 52ff417 
>   ql/src/test/results/clientpositive/drop_multi_partitions.q.out 58a472c 
>   ql/src/test/results/clientpositive/exchange_partition.q.out 381a9fd 
>   ql/src/test/results/clientpositive/index_auto_empty.q.out 6a1a6c5 
>   ql/src/test/results/clientpositive/touch.q.out 7ea3807 
>   ql/src/test/results/clientpositive/unset_table_view_property.q.out 8cf6686 
> 
> Diff: https://reviews.apache.org/r/24833/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>