[GitHub] [hadoop] xinglin commented on a diff in pull request #5367: HADOOP-18624. Leaked calls in Client.java may cause ObserverNameNode OOM

["xinglin (via GitHub)" <gi...@apache.org>]

xinglin commented on code in PR #5367:
URL: https://github.com/apache/hadoop/pull/5367#discussion_r1116566616


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1485,6 +1487,10 @@ Writable call(RPC.RpcKind rpcKind, Writable rpcRequest,
         releaseAsyncCall();
       }
       throw e;
+    } finally {
+      if (!success) {
+        connection.calls.remove(call.id);

Review Comment:
   sendRpcRequest(call) will try to add a pair of <call,buf> into rpcRequestQueue. Should we remove that on failure as well?
   
   `      rpcRequestQueue.put(Pair.of(call, buf));
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org