You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2023/05/30 07:51:44 UTC
[GitHub] [kafka] dajac commented on a diff in pull request #13770: MINOR: Add config to producerStateManager config
dajac commented on code in PR #13770:
URL: https://github.com/apache/kafka/pull/13770#discussion_r1209855532
##########
core/src/main/java/kafka/server/builders/LogManagerBuilder.java:
##########
@@ -111,7 +111,12 @@ public LogManagerBuilder setMaxTransactionTimeoutMs(int maxTransactionTimeoutMs)
}
public LogManagerBuilder setMaxProducerIdExpirationMs(int maxProducerIdExpirationMs) {
- this.producerStateManagerConfig = new ProducerStateManagerConfig(maxProducerIdExpirationMs);
+ this.producerStateManagerConfig = new ProducerStateManagerConfig(maxProducerIdExpirationMs, false);
Review Comment:
Should we remove `setMaxProducerIdExpirationMs` and use `setProducerStateManagerConfig` everywhere?
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java:
##########
@@ -24,8 +24,11 @@ public class ProducerStateManagerConfig {
public static final Set<String> RECONFIGURABLE_CONFIGS = Collections.singleton(PRODUCER_ID_EXPIRATION_MS);
private volatile int producerIdExpirationMs;
- public ProducerStateManagerConfig(int producerIdExpirationMs) {
+ private volatile boolean transactionVerificationEnabled;
Review Comment:
small nit: I would put an empty line before `producerIdExpirationMs` and remove the one between `producerIdExpirationMs` and `transactionVerificationEnabled`.
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java:
##########
@@ -24,8 +24,11 @@ public class ProducerStateManagerConfig {
public static final Set<String> RECONFIGURABLE_CONFIGS = Collections.singleton(PRODUCER_ID_EXPIRATION_MS);
private volatile int producerIdExpirationMs;
- public ProducerStateManagerConfig(int producerIdExpirationMs) {
+ private volatile boolean transactionVerificationEnabled;
Review Comment:
Do we plan to make it dynamic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org