[jira] [Commented] (THRIFT-2827) Thrift 0.9.2 fails to compile on Yosemite due to tr1/functional include in ProcessorTest.cpp

["Konrad Grochowski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213259#comment-14213259 ] 

Konrad Grochowski commented on THRIFT-2827:
-------------------------------------------

check if removing this include completely helps. I can't check right now, but looking at that cpp I can't find any usages of tr1/function/bind

> Thrift 0.9.2 fails to compile on Yosemite due to tr1/functional include in ProcessorTest.cpp
> --------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2827
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2827
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.9.2
>         Environment: OS X Yosemite
>            Reporter: Aiden Scandella
>
> I am trying to update the homebrew recipe for OS X to build Thrift 0.9.2. The current 0.9.1 formula includes many patches in order to get it building.
> Currently the only error left is in compiling processor/ProcessorTest.cpp
> processor/ProcessorTest.cpp:26:10: fatal error: 'tr1/functional' file not found
> #include <tr1/functional>
>          ^
> 1 error generated.
> make[4]: *** [processor/ProcessorTest.o] Error 1
> make[3]: *** [all-recursive] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> This file seems to have been added in THRIFT-1336 and is the only file I see that still tries to include tr1/functional directly. Ignoring this error produces a workable thrift 0.9.2 package without any custom patches.
> Homebrew issue I'm working on is here: https://github.com/Homebrew/homebrew/issues/34194
> Is this as simple as swapping out the include for thrift/cxxfunctional.h ? Or am I missing something.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)