You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by tarilabs <gi...@git.apache.org> on 2015/11/25 12:22:21 UTC
[GitHub] maven-doxia-sitetools pull request: Actually display the "open in ...
GitHub user tarilabs opened a pull request:
https://github.com/apache/maven-doxia-sitetools/pull/3
Actually display the "open in new window" icon.
I understand this is the default `site.vm` used by `(org.apache.maven.plugins/)maven-site-plugin`.
I understand default skins package `(org.apache.maven.skins/maven-skins)` including the default skin `(org.apache.maven.skins/)maven-default-skin` do provide CSS with class for links (html `<a>` tag) with "newWindow" in turn leveraging the newwindow.png made available by the skin.
Similarly to what happens for "externalLink" for external.png which is demonstrated by the already existing original code, just the line above my proposed code change.
This proposed code change do actually leverage the "newWindow" (html a) CSS class in turn leveraging the newwindow.png made available by the maven default skins.
Please notice the priority is given to the "external link" icon. If the link is NOT an external link, but it is to be opened in a new window because target is "_blank", then the relevant CSS class is applied.
Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tarilabs/maven-doxia-sitetools patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-doxia-sitetools/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 6a70b88b7d55f7317d58605f3600de956f6cf4dd
Author: tarilabs <ma...@gmail.com>
Date: 2015-11-25T11:19:52Z
Actually display the "open in new window" icon.
I understand this is the default site.vm used by (org.apache.maven.plugins/)maven-site-plugin.
I understand default skins package (org.apache.maven.skins/maven-skins) including the default skin (org.apache.maven.skins/)maven-default-skin do provide CSS with class for links (html a) with "newWindow" in turn leveraging the newwindow.png made available by the skin.
Similarly to what happens for "externalLink" for external.png which is demonstrated by the already existing original code, just the line above my proposed code changes.
This proposed code change do actually leverage the "newWindow" (html a) class in turn leveraging the newwindow.png made available by the maven default skins.
Please notice the priority is given to the "external link" icon. If the link is NOT an external link, but it is to be opened in a new window because target is "_blank", then the relevant class is applied.
Thank you.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-doxia-sitetools pull request #3: Actually display the "open in new win...
Posted by gmcdonald <gi...@git.apache.org>.
Github user gmcdonald closed the pull request at:
https://github.com/apache/maven-doxia-sitetools/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org