[PR] chore(asf.yaml): require review threads to be resolved before merge [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #1521:
URL: https://github.com/apache/magpie/pull/1521

   <!-- SPDX-License-Identifier: Apache-2.0
        https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ## Summary
   
   - Turn `required_conversation_resolution` back on for `main`: a PR can no longer merge while any review thread is unresolved.
   - With the approval requirement temporarily lifted, an open thread is the only remaining signal that a reviewer's point is still unanswered, and nothing stopped a merge past it. Resolving is cheap — the author resolves after pushing the fix, or the reviewer resolves a nit deliberately left as-is.
   - The bootstrap-phase note in the same file already says "review threads still have to be resolved"; this makes that statement true again. The comment on the setting is rewritten to give the new reasoning.
   
   ## Type of change
   
   - [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   - [ ] Tool / bridge contract (`tools/<system>/*.md`)
   - [ ] Python package (`tools/*/` with `pyproject.toml`)
   - [ ] Groovy reference impl
   - [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
   - [ ] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
   - [ ] Project template (`projects/_template/`)
   - [x] CI / dev loop (`prek`, workflows, validators)
   - [x] Other: repository configuration (`.asf.yaml` branch protection)
   
   ## Test plan
   
   - [x] Pre-commit hooks pass on the commit (including the YAML checks)
   - [ ] After merge: confirm ASF Infra reconciled the branch protection — `Require conversation resolution before merging` shows as enabled on `main` in the repo settings, and a PR with an open thread shows the merge as blocked
   
   ## RFC-AI-0004 compliance
   
   No principle touched — repository configuration only.
   
   ## Linked issues
   
   None.
   
   ## Notes for reviewers (optional)
   
   The previous comment explained why this gate was switched off: reviewers were resolving their own advisory nits purely to unblock merges. That trade-off is being reversed deliberately — an unanswered point slipping through to `main` is the worse failure. Reviewers who leave a non-blocking nit can resolve it themselves when they're happy for it to stay as-is.
   
   ---
   
   Generated-by: Claude Opus 5 (assisted; reviewed by the PR author)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore(asf.yaml): require review threads to be resolved before merge [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #1521:
URL: https://github.com/apache/magpie/pull/1521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org