You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by HansBrende <gi...@git.apache.org> on 2018/01/29 05:40:40 UTC
[GitHub] any23 pull request #62: ANY23-327 Change log level to debug for RDFUtils.isA...
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/62
ANY23-327 Change log level to debug for RDFUtils.isAbsoluteIRI()
No need to see a stack trace every time `isAbsoluteIRI` returns `false`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-327
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit c2ddb5862b14fb1099b0d0dfc2193790ad3aa2b0
Author: Hans <fi...@...>
Date: 2018-01-29T05:30:54Z
ANY23-327 Change log level to debug for RDFUtils.isAbsoluteIRI()
----
---
[GitHub] any23 pull request #62: ANY23-327 Change log level to debug for RDFUtils.isA...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/any23/pull/62
---
[GitHub] any23 issue #62: ANY23-327 Change log level to debug for RDFUtils.isAbsolute...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/62
@jgrzebyta can you merge to master?
---
[GitHub] any23 pull request #62: ANY23-327 Change log level to debug for RDFUtils.isA...
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on a diff in the pull request:
https://github.com/apache/any23/pull/62#discussion_r164340771
--- Diff: core/src/main/java/org/apache/any23/rdf/RDFUtils.java ---
@@ -528,10 +528,10 @@ public static boolean isAbsoluteIRI(String href) {
new java.net.URI(href.trim());
--- End diff --
On an unrelated note, why are we testing this on `href.trim()` instead of just `href`?
`RDFUtils.iri(href)` does *not* call `href.trim()`!
---
[GitHub] any23 pull request #62: ANY23-327 Change log level to debug for RDFUtils.isA...
Posted by jgrzebyta <gi...@git.apache.org>.
Github user jgrzebyta commented on a diff in the pull request:
https://github.com/apache/any23/pull/62#discussion_r164365746
--- Diff: core/src/main/java/org/apache/any23/rdf/RDFUtils.java ---
@@ -528,10 +528,10 @@ public static boolean isAbsoluteIRI(String href) {
new java.net.URI(href.trim());
--- End diff --
So please could you change it as well?
---