You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/19 05:14:01 UTC
[GitHub] [doris] ByteYue opened a new pull request, #16089: [wip](cooldown)accelerate cooldown task produce efficiency
ByteYue opened a new pull request, #16089:
URL: https://github.com/apache/doris/pull/16089
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by github-actions.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1410174039
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by github-actions.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1409855902
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1091429337
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -1281,39 +1281,44 @@ struct SortCtx {
SortCtx(TabletSharedPtr tablet, int64_t cooldown_timestamp, int64_t file_size)
: tablet(tablet), cooldown_timestamp(cooldown_timestamp), file_size(file_size) {}
TabletSharedPtr tablet;
- int64_t cooldown_timestamp;
+ // to ensure the tablet with -1 would always be greater than other
+ uint64_t cooldown_timestamp;
int64_t file_size;
+ bool operator<(const SortCtx& other) const {
+ if (this->cooldown_timestamp == other.cooldown_timestamp) {
+ return this->file_size > other.file_size;
+ }
+ return this->cooldown_timestamp < other.cooldown_timestamp;
+ }
};
-void TabletManager::get_cooldown_tablets(std::vector<TabletSharedPtr>* tablets) {
+void TabletManager::get_cooldown_tablets(
+ std::vector<TabletSharedPtr>* tablets,
+ std::function<bool(const TabletSharedPtr&)> cooldown_pending_predicate) {
std::vector<SortCtx> sort_ctx_vec;
+ std::vector<std::weak_ptr<Tablet>> candidates;
for (const auto& tablets_shard : _tablets_shards) {
std::shared_lock rdlock(tablets_shard.lock);
- for (const auto& item : tablets_shard.tablet_map) {
- const TabletSharedPtr& tablet = item.second;
- int64_t cooldown_timestamp = -1;
- size_t file_size = -1;
- if (tablet->need_cooldown(&cooldown_timestamp, &file_size)) {
- sort_ctx_vec.emplace_back(tablet, cooldown_timestamp, file_size);
- }
- }
- }
-
- std::sort(sort_ctx_vec.begin(), sort_ctx_vec.end(), [](SortCtx a, SortCtx b) {
- if (a.cooldown_timestamp != -1 && b.cooldown_timestamp != -1) {
- return a.cooldown_timestamp < b.cooldown_timestamp;
- }
-
- if (a.cooldown_timestamp != -1 && b.cooldown_timestamp == -1) {
- return true;
- }
-
- if (a.cooldown_timestamp == -1 && b.cooldown_timestamp != -1) {
- return false;
- }
-
- return a.file_size > b.file_size;
- });
+ std::for_each(
+ tablets_shard.tablet_map.begin(), tablets_shard.tablet_map.end(),
+ [&candidates](auto& tablet_pair) { candidates.emplace_back(tablet_pair.second); });
+ }
+ std::for_each(candidates.begin(), candidates.end(),
+ [&sort_ctx_vec, &cooldown_pending_predicate](std::weak_ptr<Tablet>& t) {
+ if (UNLIKELY(t.expired())) {
+ return;
+ }
+ const TabletSharedPtr& tablet = t.lock();
+ std::shared_lock rdlock(tablet->get_header_lock());
+ int64_t cooldown_timestamp = -1;
+ size_t file_size = -1;
+ if (cooldown_pending_predicate(tablet) ||
+ tablet->need_cooldown(&cooldown_timestamp, &file_size)) {
Review Comment:
`||` seems wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1396480937
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1398373143
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1396466616
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1082136781
##########
be/src/olap/olap_server.cpp:
##########
@@ -684,42 +685,19 @@ Status StorageEngine::submit_seg_compaction_task(BetaRowsetWriter* writer,
void StorageEngine::_cooldown_tasks_producer_callback() {
int64_t interval = config::generate_cooldown_task_interval_sec;
+ phmap::parallel_flat_hash_set<int64_t> cooldown_pending_tabelts;
do {
- if (_cooldown_thread_pool->get_queue_size() > 0) {
- continue;
- }
+ // these tables are ordered by priority desc
std::vector<TabletSharedPtr> tablets;
// TODO(luwei) : a more efficient way to get cooldown tablets
_tablet_manager->get_cooldown_tablets(&tablets);
Review Comment:
warning: too few arguments to function call, expected 2, have 1 [clang-diagnostic-error]
```cpp
_tablet_manager->get_cooldown_tablets(&tablets);
^
```
**be/src/olap/tablet_manager.h:138:** 'get_cooldown_tablets' declared here
```cpp
nfo_on_disk);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1398403587
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1398359137
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by github-actions.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1409798866
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #16089:
URL: https://github.com/apache/doris/pull/16089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1080818135
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -1272,40 +1272,44 @@ struct SortCtx {
SortCtx(TabletSharedPtr tablet, int64_t cooldown_timestamp, int64_t file_size)
: tablet(tablet), cooldown_timestamp(cooldown_timestamp), file_size(file_size) {}
TabletSharedPtr tablet;
- int64_t cooldown_timestamp;
+ // to ensure the tablet with -1 would always be greater than other
+ uint64_t cooldown_timestamp;
int64_t file_size;
+ bool operator<(const SortCtx& other) const {
+ if (this->cooldown_timestamp == other.cooldown_timestamp) {
+ return this->file_size > other.file_size;
+ }
+ return this->cooldown_timestamp < other.cooldown_timestamp;
+ }
};
void TabletManager::get_cooldown_tablets(std::vector<TabletSharedPtr>* tablets) {
std::vector<SortCtx> sort_ctx_vec;
+ std::vector<std::weak_ptr<Tablet>> candidates;
for (const auto& tablets_shard : _tablets_shards) {
std::shared_lock rdlock(tablets_shard.lock);
- for (const auto& item : tablets_shard.tablet_map) {
- const TabletSharedPtr& tablet = item.second;
- int64_t cooldown_timestamp = -1;
- size_t file_size = -1;
- if (tablet->need_cooldown(&cooldown_timestamp, &file_size)) {
- sort_ctx_vec.emplace_back(tablet, cooldown_timestamp, file_size);
- }
- }
- }
-
- std::sort(sort_ctx_vec.begin(), sort_ctx_vec.end(), [](SortCtx a, SortCtx b) {
- if (a.cooldown_timestamp != -1 && b.cooldown_timestamp != -1) {
- return a.cooldown_timestamp < b.cooldown_timestamp;
- }
-
- if (a.cooldown_timestamp != -1 && b.cooldown_timestamp == -1) {
- return true;
+ std::for_each(tablets_shard.tablet_map.begin(), tablets_shard.tablet_map.end(),
+ [&candidates](auto& tablet_pair) {
+ candidates.emplace_back(tablet_pair.second.tablet->weak_from_this());
Review Comment:
warning: no member named 'tablet' in 'std::shared_ptr<doris::Tablet>' [clang-diagnostic-error]
```cpp
candidates.emplace_back(tablet_pair.second.tablet->weak_from_this());
^
```
**/usr/include/c++/11/bits/stl_algo.h:3819:** in instantiation of function template specialization 'doris::TabletManager::get_cooldown_tablets(std::vector<TabletSharedPtr> *)::(anonymous class)::operator()<const std::pair<const long, std::shared_ptr<doris::Tablet>>>' requested here
```cpp
__f(*__first);
^
```
**be/src/olap/tablet_manager.cpp:1290:** in instantiation of function template specialization 'std::for_each<std::__detail::_Node_const_iterator<std::pair<const long, std::shared_ptr<doris::Tablet>>, false, false>, (lambda at /github/workspace/be/src/olap/tablet_manager.cpp:1292:23)>' requested here
```cpp
std::for_each(tablets_shard.tablet_map.begin(), tablets_shard.tablet_map.end(),
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1091405271
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -1281,39 +1281,44 @@ struct SortCtx {
SortCtx(TabletSharedPtr tablet, int64_t cooldown_timestamp, int64_t file_size)
: tablet(tablet), cooldown_timestamp(cooldown_timestamp), file_size(file_size) {}
TabletSharedPtr tablet;
- int64_t cooldown_timestamp;
+ // to ensure the tablet with -1 would always be greater than other
+ uint64_t cooldown_timestamp;
int64_t file_size;
+ bool operator<(const SortCtx& other) const {
+ if (this->cooldown_timestamp == other.cooldown_timestamp) {
+ return this->file_size > other.file_size;
+ }
+ return this->cooldown_timestamp < other.cooldown_timestamp;
+ }
};
-void TabletManager::get_cooldown_tablets(std::vector<TabletSharedPtr>* tablets) {
+void TabletManager::get_cooldown_tablets(
+ std::vector<TabletSharedPtr>* tablets,
+ std::function<bool(const TabletSharedPtr&)> cooldown_pending_predicate) {
std::vector<SortCtx> sort_ctx_vec;
+ std::vector<std::weak_ptr<Tablet>> candidates;
for (const auto& tablets_shard : _tablets_shards) {
std::shared_lock rdlock(tablets_shard.lock);
- for (const auto& item : tablets_shard.tablet_map) {
- const TabletSharedPtr& tablet = item.second;
- int64_t cooldown_timestamp = -1;
- size_t file_size = -1;
- if (tablet->need_cooldown(&cooldown_timestamp, &file_size)) {
- sort_ctx_vec.emplace_back(tablet, cooldown_timestamp, file_size);
- }
- }
- }
-
- std::sort(sort_ctx_vec.begin(), sort_ctx_vec.end(), [](SortCtx a, SortCtx b) {
- if (a.cooldown_timestamp != -1 && b.cooldown_timestamp != -1) {
- return a.cooldown_timestamp < b.cooldown_timestamp;
- }
-
- if (a.cooldown_timestamp != -1 && b.cooldown_timestamp == -1) {
- return true;
- }
-
- if (a.cooldown_timestamp == -1 && b.cooldown_timestamp != -1) {
- return false;
- }
-
- return a.file_size > b.file_size;
- });
+ std::for_each(
+ tablets_shard.tablet_map.begin(), tablets_shard.tablet_map.end(),
+ [&candidates](auto& tablet_pair) { candidates.emplace_back(tablet_pair.second); });
+ }
+ std::for_each(candidates.begin(), candidates.end(),
+ [&sort_ctx_vec, &cooldown_pending_predicate](std::weak_ptr<Tablet>& t) {
+ if (UNLIKELY(t.expired())) {
Review Comment:
weak_ptr should be used in this way:
```
auto tablet = t.lock();
if (tablet == nullptr) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1095337698
##########
be/test/olap/tablet_test.cpp:
##########
@@ -322,6 +320,7 @@ TEST_F(TestTablet, cooldown_policy) {
_tablet->_rs_version_map[ptr5->version()] = rowset5;
Review Comment:
warning: '_rs_version_map' is a private member of 'doris::Tablet' [clang-diagnostic-error]
```cpp
_tablet->_rs_version_map[ptr5->version()] = rowset5;
^
```
**be/src/olap/tablet.h:437:** declared private here
```cpp
std::unordered_map<Version, RowsetSharedPtr, HashOfVersion> _rs_version_map;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1398056898
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16089: [wip](cooldown)accelerate cooldown task produce efficiency
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1398137774
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.51 seconds
load time: 482 seconds
storage size: 17119322801 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230120093839_clickbench_pr_84623.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by github-actions.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1411599264
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1413080607
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1413080642
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16089:
URL: https://github.com/apache/doris/pull/16089#issuecomment-1413803974
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org