[GitHub] [ozone] sodonnel commented on a change in pull request #2849: HDDS-5955: EC: Track the failed servers to add into the excludeList when invoking allocateBlock

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2849:
URL: https://github.com/apache/ozone/pull/2849#discussion_r752231631



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockOutputStreamEntry.java
##########
@@ -291,8 +297,9 @@ private BlockID underlyingBlockID() {
    *                   futures if false.
    * @return
    */
-  public boolean checkStreamFailures(boolean forPutBlock) {
+  public List<ECBlockOutputStream> getFailedStreams(boolean forPutBlock) {
     final Iterator<ECBlockOutputStream> iter = blockStreams().iterator();
+    List<ECBlockOutputStream> failedStream = new ArrayList<>();

Review comment:
       Nit: It would read better if `failedStream` was named `failedStreams` as it is a list of streams rather than a single stream.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org