[GitHub] nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232001621
 
 

 ##########
 File path: src/chttpd/src/chttpd_db.erl
 ##########
 @@ -476,19 +477,59 @@ db_req(#httpd{method='POST', path_parts=[_, <<"_bulk_get">>]}=Req, Db) ->
             #doc_query_args{
                 options = Options
             } = bulk_get_parse_doc_query(Req),
-
-            {ok, Resp} = start_json_response(Req, 200),
-            send_chunk(Resp, <<"{\"results\": [">>),
-
-            lists:foldl(fun(Doc, Sep) ->
-                {DocId, Results, Options1} = bulk_get_open_doc_revs(Db, Doc,
-                                                                    Options),
-                bulk_get_send_docs_json(Resp, DocId, Results, Options1, Sep),
-                <<",">>
-            end, <<"">>, Docs),
-
-            send_chunk(Resp, <<"]}">>),
-            end_json_response(Resp)
+            % Decide whether to use multipart response or application/json
+            AcceptMixedMp = MochiReq:accepts_content_type("multipart/mixed"),
+            AcceptRelatedMp = MochiReq:accepts_content_type("multipart/related"),
+            AcceptMp = AcceptMixedMp orelse AcceptRelatedMp,
+            case AcceptMp of
+               false ->
+                  {ok, Resp} = start_json_response(Req, 200),
+                  send_chunk(Resp, <<"{\"results\": [">>),
+                  lists:foldl(fun(Doc, Sep) ->
+                      {DocId, Results, Options1} = bulk_get_open_doc_revs(Db, Doc,
+                                                                          Options),
 
 Review comment:
   Indent this 4 space to the right `{DocId..` on previous line:
   
   ```
   {DocId, Results, ...}
       Options)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services