[GitHub] [tvm] lhutton1 commented on a diff in pull request #10801: [BYOC][ACL] Fix list is not supported as an input node

[GitBox <gi...@apache.org>]

lhutton1 commented on code in PR #10801:
URL: https://github.com/apache/tvm/pull/10801#discussion_r849250815


##########
python/tvm/relay/op/contrib/arm_compute_lib.py:
##########
@@ -52,11 +56,15 @@ def partition_for_arm_compute_lib(mod, params=None, **opts):
         The module to run passes on.
     params : Optional[Dict[str, NDArray]]
         Constant input parameters.
+    offload_concat : Optional[bool]
+        Whether offload concatenate
 
     Returns
     -------
     ret : annotated and partitioned module.
     """
+    global offload_concat_

Review Comment:
   Thanks for taking a look @masahi. Currently ACL has a mixture of registering operations using composite functions and `_register_external_op_helper` which adds the `target.arm_compute_lib` attribute, which is not ideal. I think if we wanted to do this for concat it would need to be registered using pattern table rather than the other mechanism.
   
   In the future we should probably use the pattern table for all operations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org