You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/06/13 02:44:42 UTC
Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jason Lai.
Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Diffs
-----
src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c
Diff: https://reviews.apache.org/r/67565/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204839
-----------------------------------------------------------
PASS: Mesos patch 67565 was successfully built and tested.
Reviews applied: `['67563', '67526', '67564', '67565']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67565
- Mesos Reviewbot Windows
On June 15, 2018, 11:55 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 11:55 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c
>
>
> Diff: https://reviews.apache.org/r/67565/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204889
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67563, 67526, 67564, 67565]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 15, 2018, 4:55 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 4:55 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c
>
>
> Diff: https://reviews.apache.org/r/67565/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review205040
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67526.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67526`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67565
Relevant logs:
- [apply-review-67526-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67565/logs/apply-review-67526-stdout.log):
```
error: patch failed: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp:14
error: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On June 20, 2018, 10:40 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 10:40 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp d1028e351c2ff395adc48489169597adbb0ce857
>
>
> Diff: https://reviews.apache.org/r/67565/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review205275
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On June 19, 2018, 7:40 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 7:40 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp d1028e351c2ff395adc48489169597adbb0ce857
>
>
> Diff: https://reviews.apache.org/r/67565/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review205045
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67662, 67526, 67564, 67565]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 20, 2018, 2:40 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 2:40 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp d1028e351c2ff395adc48489169597adbb0ce857
>
>
> Diff: https://reviews.apache.org/r/67565/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
-----------------------------------------------------------
(Updated June 20, 2018, 10:40 a.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp d1028e351c2ff395adc48489169597adbb0ce857
Diff: https://reviews.apache.org/r/67565/diff/3/
Changes: https://reviews.apache.org/r/67565/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
-----------------------------------------------------------
(Updated June 15, 2018, 7:55 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c
Diff: https://reviews.apache.org/r/67565/diff/2/
Changes: https://reviews.apache.org/r/67565/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204708
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67563, 67526, 67564, 67565]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 13, 2018, 2:44 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 2:44 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c
>
>
> Diff: https://reviews.apache.org/r/67565/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67565: Added a test
`ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/#review204660
-----------------------------------------------------------
PASS: Mesos patch 67565 was successfully built and tested.
Reviews applied: `['67563', '67526', '67564', '67565']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67565
- Mesos Reviewbot Windows
On June 12, 2018, 7:44 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67565/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 7:44 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c
>
>
> Diff: https://reviews.apache.org/r/67565/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>