[GitHub] [openwhisk] rabbah commented on a change in pull request #5137: Add retry logic of save activation

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #5137:
URL: https://github.com/apache/openwhisk/pull/5137#discussion_r664853039



##########
File path: common/scala/src/main/resources/application.conf
##########
@@ -344,6 +344,13 @@ whisk {
     #   }
     # }
 
+    activation-store {

Review comment:
       is this stanza required? If not specified is there a default policy (no retry?) assumed?
   Since this has no backoff policy, the retry here is really only handling transient failures.

##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/CouchDbRestStore.scala
##########
@@ -74,8 +75,10 @@ class CouchDbRestStore[DocumentAbstraction <: DocumentSerializer](dbProtocol: St
   // and more documents need to be stored, then all arriving documents will be put into batches (if enabled) to avoid a long queue.
   private val maxOpenDbRequests = system.settings.config.getInt("akka.http.host-connection-pool.max-connections") / 2
 
+  private val maxRetry = loadConfigOrThrow[Int]("whisk.activation-store.retry-config.max-tries")
+  private val retryDelay = loadConfigOrThrow[FiniteDuration]("whisk.activation-store.retry-config.retry-delay")

Review comment:
       looks like the section is required?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org