You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by dalaro <gi...@git.apache.org> on 2016/08/11 00:01:12 UTC

[GitHub] tinkerpop pull request #377: TINKERPOP-1397 StarGraph filtering with self ed...

GitHub user dalaro opened a pull request:

    https://github.com/apache/tinkerpop/pull/377

    TINKERPOP-1397 StarGraph filtering with self edges

    See:
    
    * old PR #372
    * JIRA issue https://issues.apache.org/jira/browse/TINKERPOP-1397

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dalaro/incubator-tinkerpop TINKERPOP-1397

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #377
    
----
commit 0022b7f6be25eb7d3c778b137beb6e8a7d2784ca
Author: Dan LaRocque <da...@hopcount.org>
Date:   2016-08-10T22:52:13Z

    TINKERPOP-1397 Fix StarGraph.addEdge
    
    For self-loops, StarGraph.addEdge used to put a single StarOutEdge
    into both its inEdges and outEdges maps, potentially causing problems
    in applyGraphFilter.
    
    This change makes StarGraph.addEdge put the appropriate type of edge
    (Star(Out/In)Edge) in the associated map.  The IDs for each edge
    instance are kept in agreement.
    
    This change is @okram's, who suggested it in PR #372.  I merely
    reviewed it and added a couple of comments.

commit 7842c4e7e2e3c2b33fc1bca7a8a80e165080bc59
Author: Dan LaRocque <da...@hopcount.org>
Date:   2016-08-10T22:59:54Z

    TINKERPOP-1397 Add StarGraph bothE filtering test

commit b4aaa69b9c10a61c7ab2f7476c90e4728ef032e8
Author: Dan LaRocque <da...@hopcount.org>
Date:   2016-08-10T23:24:10Z

    Merge branch 'TINKERPOP-1397-tp31' into TINKERPOP-1397

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #377: TINKERPOP-1397 StarGraph filtering with self ed...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/377


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #377: TINKERPOP-1397 StarGraph filtering with self edges

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/377
  
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #377: TINKERPOP-1397 StarGraph filtering with self edges

Posted by okram <gi...@git.apache.org>.

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/377
  
    This solution makes sense to me -- no new `SelfEdge` class and we now have a test case. Thanks.
    
    VOTE +1. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #377: TINKERPOP-1397 StarGraph filtering with self edges

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/377
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---