You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/11 15:05:29 UTC
[GitHub] [airflow] owlphi opened a new pull request #13018: Add project-id to client inside bigquery hook update-table
owlphi opened a new pull request #13018:
URL: https://github.com/apache/airflow/pull/13018
# Problem
I am trying to update my table using the bigquery hook.
bq_hook.update_table(...)
However I got this message:
```
google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
```
# Solution
In the update_table method
I have modified the line https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/hooks/bigquery.py#L717
from :
`table_object = self.get_client().update_table(table=table, fields=fields)`
to:
`table_object = self.get_client(project_id=project_id).update_table(table=table, fields=fields)`
It seems working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
owlphi commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-743309697
Hi @mik-laj, No worries, I will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-743245217
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-743787661
[The Workflow run](https://github.com/apache/airflow/actions/runs/417650644) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #13018:
URL: https://github.com/apache/airflow/pull/13018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-743787742
[The Workflow run](https://github.com/apache/airflow/actions/runs/417618140) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-743306856
Can you add unit tests to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-743351232
[The Workflow run](https://github.com/apache/airflow/actions/runs/416013219) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13018: Add project-id to client inside bigquery hook update-table
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13018:
URL: https://github.com/apache/airflow/pull/13018#issuecomment-744325512
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org