You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason Dillon (JIRA)" <ji...@codehaus.org> on 2007/03/30 00:29:34 UTC

[jira] Created: (MANTTASKS-42) Allow install and deploy tasks to include attached artifacts

Allow install and deploy tasks to include attached artifacts
------------------------------------------------------------

                 Key: MANTTASKS-42
                 URL: http://jira.codehaus.org/browse/MANTTASKS-42
             Project: Maven 2.x Ant Tasks
          Issue Type: New Feature
            Reporter: Jason Dillon


The install and deploy tasks should be able to include additional artifacts to _attach_ when performing install/deploy operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MANTTASKS-42) Allow install and deploy tasks to include attached artifacts

Posted by "Jason Dillon (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MANTTASKS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91610 ] 

Jason Dillon commented on MANTTASKS-42:
---------------------------------------

Added feature branch in the maven sandbox with this patch applied:

 * https://svn.apache.org/repos/asf/maven/sandbox/trunk/ant-tasks/install-deploy-attached


> Allow install and deploy tasks to include attached artifacts
> ------------------------------------------------------------
>
>                 Key: MANTTASKS-42
>                 URL: http://jira.codehaus.org/browse/MANTTASKS-42
>             Project: Maven 2.x Ant Tasks
>          Issue Type: New Feature
>            Reporter: Jason Dillon
>         Attachments: MANTTASKS-42.diff
>
>
> The install and deploy tasks should be able to include additional artifacts to _attach_ when performing install/deploy operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MANTTASKS-42) Allow install and deploy tasks to include attached artifacts

Posted by "Jason Dillon (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MANTTASKS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91609 ] 

Jason Dillon commented on MANTTASKS-42:
---------------------------------------

I don't think it is related to this change, but I noticed that a NPE gets throw when doing:

{noformat}
ant -f ./sample.build.xml test-install-attached test-deploy-attached
{noformat}

This spits out:

{noformat}
Buildfile: ./sample.build.xml

initTaskDefs:

test-install-attached:
[artifact:install] [INFO] Installing /Users/jason/ws/maven/install-deploy-attached/sample-build-test.pom to /Users/jason/ws/maven/install-deploy-attached/target/local-repo/org/apache/maven/test/sample-build-test/2.0-beta-4-SNAPSHOT/sample-build-test-2.0-beta-4-SNAPSHOT.jar
[artifact:install] [INFO] Installing /Users/jason/ws/maven/install-deploy-attached/target/sample-build-test.pom.asc to /Users/jason/ws/maven/install-deploy-attached/target/local-repo/org/apache/maven/test/sample-build-test/2.0-beta-4-SNAPSHOT/sample-build-test-2.0-beta-4-SNAPSHOT.pom.asc

initTaskDefs:

BUILD FAILED
/Users/jason/ws/maven/install-deploy-attached/sample.build.xml:37: java.lang.NullPointerException
{noformat}

The NPE comes from:

{code}
<artifact:pom file="pom.xml" id="maven.project"/>
{code}


> Allow install and deploy tasks to include attached artifacts
> ------------------------------------------------------------
>
>                 Key: MANTTASKS-42
>                 URL: http://jira.codehaus.org/browse/MANTTASKS-42
>             Project: Maven 2.x Ant Tasks
>          Issue Type: New Feature
>            Reporter: Jason Dillon
>         Attachments: MANTTASKS-42.diff
>
>
> The install and deploy tasks should be able to include additional artifacts to _attach_ when performing install/deploy operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MANTTASKS-42) Allow install and deploy tasks to include attached artifacts

Posted by "Jason Dillon (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MANTTASKS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon updated MANTTASKS-42:
----------------------------------

    Attachment: MANTTASKS-42.diff

Attached patch adds support for nested {{<attach>}} elements for deploy and install, suitable for use like:

{code}
<target name="test-deploy-attached" depends="initTaskDefs">
    <echo message="test" file="${basedir}/target/sample-build-test.pom.asc"/>

    <artifact:deploy file="sample-build-test.pom">
        <pom file="sample-build-test.pom" />
        <remoteRepository refid="deploy.repository" />
        <attach file="${basedir}/target/sample-build-test.pom.asc" type="pom.asc"/>
    </artifact:deploy>
</target>

<target name="test-install-attached" depends="initTaskDefs">
    <echo message="test" file="${basedir}/target/sample-build-test.pom.asc"/>

    <artifact:install file="sample-build-test.pom">
        <pom file="sample-build-test.pom" />
        <localRepository refid="local.repository"/>
        <attach file="${basedir}/target/sample-build-test.pom.asc" type="pom.asc"/>
    </artifact:install>
</target>
{code}

Adds a {{InstallDeployTaskSupport}} class to hold common code, {{InstallTask}} and {{DeployTask}} extend from it.

Adds a {{AttachedArtifact}} class to hold the attached artifact details (file, type and classifier).

To get this to build I had to change the maven artifacts to use {{2.0.6}} (and build the maven-2.0.6 tag of the components tree).

I updated the {{sample.build.xml}} to add {{test-install-attached}} and {{test-deploy-attached}} targets to test with, as well as changed the layout of the {{deploy.repository}} to {{default}}.

Sorry, I tried to keep close the the current style, but its not easy to make my fingers add all that extra whitespace, so you prolly wanna reformat the new bits.


> Allow install and deploy tasks to include attached artifacts
> ------------------------------------------------------------
>
>                 Key: MANTTASKS-42
>                 URL: http://jira.codehaus.org/browse/MANTTASKS-42
>             Project: Maven 2.x Ant Tasks
>          Issue Type: New Feature
>            Reporter: Jason Dillon
>         Attachments: MANTTASKS-42.diff
>
>
> The install and deploy tasks should be able to include additional artifacts to _attach_ when performing install/deploy operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MANTTASKS-42) Allow install and deploy tasks to include attached artifacts

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MANTTASKS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl closed MANTTASKS-42.
----------------------------------

    Resolution: Fixed

Feature branch merged, thanks.

> Allow install and deploy tasks to include attached artifacts
> ------------------------------------------------------------
>
>                 Key: MANTTASKS-42
>                 URL: http://jira.codehaus.org/browse/MANTTASKS-42
>             Project: Maven 2.x Ant Tasks
>          Issue Type: New Feature
>            Reporter: Jason Dillon
>         Assigned To: Jason van Zyl
>             Fix For: 1.0-alpha-1
>
>         Attachments: MANTTASKS-42.diff
>
>
> The install and deploy tasks should be able to include additional artifacts to _attach_ when performing install/deploy operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MANTTASKS-42) Allow install and deploy tasks to include attached artifacts

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MANTTASKS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason van Zyl updated MANTTASKS-42:
-----------------------------------

    Fix Version/s: 1.0-alpha-1

> Allow install and deploy tasks to include attached artifacts
> ------------------------------------------------------------
>
>                 Key: MANTTASKS-42
>                 URL: http://jira.codehaus.org/browse/MANTTASKS-42
>             Project: Maven 2.x Ant Tasks
>          Issue Type: New Feature
>            Reporter: Jason Dillon
>         Assigned To: Jason van Zyl
>             Fix For: 1.0-alpha-1
>
>         Attachments: MANTTASKS-42.diff
>
>
> The install and deploy tasks should be able to include additional artifacts to _attach_ when performing install/deploy operations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira