You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by he yi hua <yh...@163.com> on 2018/06/13 23:31:22 UTC
Review Request 67591: Improving the accuracy of this failure message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Improving the accuracy of this failure message.
Diffs
-----
src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91
Diff: https://reviews.apache.org/r/67591/diff/1/
Testing
-------
Thanks,
he yi hua
Re: Review Request 67591: Improving the accuracy of this failure
message.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/#review204753
-----------------------------------------------------------
PASS: Mesos patch 67591 was successfully built and tested.
Reviews applied: `['67591']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67591
- Mesos Reviewbot Windows
On June 13, 2018, 11:31 p.m., he yi hua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67591/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 11:31 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improving the accuracy of this failure message.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91
>
>
> Diff: https://reviews.apache.org/r/67591/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> he yi hua
>
>
Re: Review Request 67591: Improving the accuracy of this failure
message.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/#review204803
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67591]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 13, 2018, 11:31 p.m., he yi hua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67591/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 11:31 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improving the accuracy of this failure message.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91
>
>
> Diff: https://reviews.apache.org/r/67591/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> he yi hua
>
>
Re: Review Request 67591: Improving the accuracy of this failure
message.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/#review205202
-----------------------------------------------------------
Fix it, then Ship it!
src/uri/fetchers/docker.cpp
Lines 875 (patched)
<https://reviews.apache.org/r/67591/#comment288130>
"Unexpected BASIC Authorization response status: " + repsponse.status);
- Gilbert Song
On June 21, 2018, 12:22 p.m., he yi hua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67591/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 12:22 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8106
> https://issues.apache.org/jira/browse/MESOS-8106
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improving the accuracy of this failure message.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91
>
>
> Diff: https://reviews.apache.org/r/67591/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> he yi hua
>
>
Re: Review Request 67591: Improving the accuracy of this failure
message.
Posted by he yi hua <yh...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67591/
-----------------------------------------------------------
(Updated June 21, 2018, 12:22 p.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-8106
https://issues.apache.org/jira/browse/MESOS-8106
Repository: mesos
Description
-------
Improving the accuracy of this failure message.
Diffs
-----
src/uri/fetchers/docker.cpp a04f71db019ae15f278c158fd0f499fb4b360e91
Diff: https://reviews.apache.org/r/67591/diff/1/
Testing
-------
Thanks,
he yi hua