[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38485: [SPARK-41001] [CONNECT] [PYTHON] Implementing Connection String for Python Client

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38485:
URL: https://github.com/apache/spark/pull/38485#discussion_r1040582062


##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -167,6 +171,43 @@ def test_simple_datasource_read(self) -> None:
             self.assertEqual(len(expectResult), len(actualResult))
 
 
+class ChannelBuilderTests(ReusedPySparkTestCase):

Review Comment:
   This should be skipped by `should_test_connect` like `SparkConnectSQLTestCase` in this file.
   ```
   @unittest.skipIf(not should_test_connect, connect_requirement_message)
   class SparkConnectSQLTestCase(ReusedPySparkTestCase):
   ```
   
   I made a PR for that.
   - https://github.com/apache/spark/pull/38931/files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org