You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/13 10:38:12 UTC

[GitHub] [airflow] alexshires opened a new pull request #15819: Update gcp_container_operator.py

alexshires opened a new pull request #15819:
URL: https://github.com/apache/airflow/pull/15819


   Adding "use_internal_ip" option to backport from the Airflow 2 GKEStartPodOperator to allow the currently deployed version of Cloud Composer to support private endpoints.
   
   
   Hi Airflow team, I would like to bring the GKEPodOperator in Airflow 1 in line with the GKEStartPodOperator in Airflow 2 with the addition of the "internal_ip" option to connect to GKE clusters with private endpoints. 
   
   I'm not what your policy is on improving this, but whilst it's in 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15819: Update gcp_container_operator.py

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-840518930






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] alexshires commented on pull request #15819: Update gcp_container_operator.py

Posted by GitBox <gi...@apache.org>.
alexshires commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-840569510


   tests fail with "pull access denied for prestosql/presto, repository does not exist or may require 'docker login': denied: requested access to the resource is denied" - what's the fix? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj closed pull request #15819: Update gcp_container_operator.py with internal_ip functionality

Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #15819:
URL: https://github.com/apache/airflow/pull/15819


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15819: Update gcp_container_operator.py

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-840519105


   [The Workflow run](https://github.com/apache/airflow/actions/runs/838793129) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15819: Update gcp_container_operator.py

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-840519257






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] alexshires commented on pull request #15819: Update gcp_container_operator.py with internal_ip functionality

Posted by GitBox <gi...@apache.org>.
alexshires commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-841145740


   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #15819: Update gcp_container_operator.py with internal_ip functionality

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-840915590


   Hi. Airflow 1.0 no longer receives any new features. If you want to use this provider then you should use [Google backport providers packages](https://pypi.org/project/apache-airflow-backport-providers-google/) which are preinstalled in the Cloud Composer environment. These packages contain all operators from Airflow 2.0, but we've finished updating packages as well, as agreed by the community. See: https://lists.apache.org/thread.html/rb34212bd13c44aa61e793d0fef14f4ab9d9408939b1b98dc814cf274%40%3Cdev.airflow.apache.org%3E


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #15819: Update gcp_container_operator.py with internal_ip functionality

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15819:
URL: https://github.com/apache/airflow/pull/15819#issuecomment-840916087


   and 
   https://cloud.google.com/composer/docs/backport-packages
   https://cloud.google.com/composer/docs/concepts/versioning/composer-versions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org