[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter files

["Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101320 ] 

Fabrice BELLINGARD commented on MASSEMBLY-178:
----------------------------------------------

MASSEMBLY-154 added the possibility to filter fileSets. 

I tested your example, and with the following assembly descriptor, the filtering works fine:

{code:xml}
<assembly>
	<id>bin</id>
	<formats>
		<format>zip</format>
	</formats>
	<fileSets>
		<fileSet>
			<directory>target</directory>
			<outputDirectory></outputDirectory>
			<includes>
				<include>*.jar</include>
			</includes>
		</fileSet>
		<fileSet>
			<directory>${basedir}</directory>
			<outputDirectory>/</outputDirectory>
			<includes>
				<include>README</include>
			</includes>
			<filtered>true</filtered>
		</fileSet>
	</fileSets>
</assembly>
{code}

Please note that I had to specify "${basedir}" for the <directory> of the 2nd fileSet to make it work. In your first assembly descriptor, a "/" was used instead, which prevented the README file from being filtered.

> filtering doesn't read filter files
> -----------------------------------
>
>                 Key: MASSEMBLY-178
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-178
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
>            Reporter: Paul Jungwirth
>            Priority: Minor
>         Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira