svn commit: r1626266 - in /commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile: AccessFlags.java Attribute.java Constant.java ConstantCP.java ElementValue.java

[se...@apache.org]

Author: sebb
Date: Fri Sep 19 16:26:51 2014
New Revision: 1626266

URL: http://svn.apache.org/r1626266
Log:
Add some TODOs

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/AccessFlags.java
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Constant.java
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ConstantCP.java
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ElementValue.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/AccessFlags.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/AccessFlags.java?rev=1626266&r1=1626265&r2=1626266&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/AccessFlags.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/AccessFlags.java Fri Sep 19 16:26:51 2014
@@ -29,7 +29,7 @@ import org.apache.bcel.Constants;
 public abstract class AccessFlags implements java.io.Serializable {
 
     private static final long serialVersionUID = 2845404654039163061L;
-    protected int access_flags;
+    protected int access_flags; // TODO make private (has getter & setter)
 
 
     public AccessFlags() {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java?rev=1626266&r1=1626265&r2=1626266&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java Fri Sep 19 16:26:51 2014
@@ -52,13 +52,13 @@ public abstract class Attribute implemen
 {
     private static final long serialVersionUID = -1707826820310002955L;
 
-    protected int name_index; // Points to attribute name in constant pool
+    protected int name_index; // Points to attribute name in constant pool TODO make private (has getter & setter)
 
-    protected int length; // Content length of attribute field
+    protected int length; // Content length of attribute field TODO make private (has getter & setter)
 
-    protected byte tag; // Tag to distiguish subclasses
+    protected byte tag; // Tag to distinguish subclasses TODO make private & final; supposed to be immutable
 
-    protected ConstantPool constant_pool;
+    protected ConstantPool constant_pool; // TODO make private (has getter & setter)
 
     protected Attribute(byte tag, int name_index, int length,
             ConstantPool constant_pool)

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Constant.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Constant.java?rev=1626266&r1=1626265&r2=1626266&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Constant.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Constant.java Fri Sep 19 16:26:51 2014
@@ -58,7 +58,7 @@ public abstract class Constant implement
      * need the tag as an index to select the corresponding class name from the 
      * `CONSTANT_NAMES' array.
      */
-    protected byte tag;
+    protected byte tag; // TODO should be private & final
 
 
     Constant(byte tag) {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ConstantCP.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ConstantCP.java?rev=1626266&r1=1626265&r2=1626266&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ConstantCP.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ConstantCP.java Fri Sep 19 16:26:51 2014
@@ -37,8 +37,8 @@ public abstract class ConstantCP extends
     private static final long serialVersionUID = -6275762995206209402L;
     /** References to the constants containing the class and the field signature
      */
-    protected int class_index;
-    protected int name_and_type_index;
+    protected int class_index; // TODO make private (has getter & setter)
+    protected int name_and_type_index; // TODO make private (has getter & setter)
 
 
     /**

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ElementValue.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ElementValue.java?rev=1626266&r1=1626265&r2=1626266&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ElementValue.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/ElementValue.java Fri Sep 19 16:26:51 2014
@@ -28,9 +28,9 @@ import java.io.IOException;
  */
 public abstract class ElementValue
 {
-    protected int type;
+    protected int type; // TODO should be final
 
-    protected ConstantPool cpool;
+    protected ConstantPool cpool; // TODO should be final
 
     @Override
     public String toString()