You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2021/12/22 16:24:17 UTC
[lucenenet] 01/04: BREAKING: Lucene.Net.TestFramework.Store.MockDirectoryWrapper: Renamed AssertNoUnreferencedFilesOnClose to AssertNoUnreferencedFilesOnDispose
This is an automated email from the ASF dual-hosted git repository.
nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git
commit e3c7e053c6433b1dfa09265ef804073dbd32ed7c
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Wed Dec 22 21:08:52 2021 +0700
BREAKING: Lucene.Net.TestFramework.Store.MockDirectoryWrapper: Renamed AssertNoUnreferencedFilesOnClose to AssertNoUnreferencedFilesOnDispose
---
src/Lucene.Net.TestFramework/Store/MockDirectoryWrapper.cs | 2 +-
src/Lucene.Net.Tests.Misc/Index/TestIndexSplitter.cs | 2 +-
src/Lucene.Net.Tests/Index/TestCrash.cs | 6 +++---
src/Lucene.Net.Tests/Index/TestDoc.cs | 4 ++--
src/Lucene.Net.Tests/Index/TestIndexWriterWithThreads.cs | 2 +-
src/Lucene.Net.Tests/Index/TestStressIndexing.cs | 2 +-
src/Lucene.Net.Tests/Index/TestTransactions.cs | 4 ++--
7 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/Lucene.Net.TestFramework/Store/MockDirectoryWrapper.cs b/src/Lucene.Net.TestFramework/Store/MockDirectoryWrapper.cs
index c341334..42b0d13 100644
--- a/src/Lucene.Net.TestFramework/Store/MockDirectoryWrapper.cs
+++ b/src/Lucene.Net.TestFramework/Store/MockDirectoryWrapper.cs
@@ -896,7 +896,7 @@ namespace Lucene.Net.Store
// NOTE: this is off by default; see LUCENE-5574
private bool assertNoUnreferencedFilesOnClose;
- public virtual bool AssertNoUnreferencedFilesOnClose // LUCENENET TODO: Rename AssertNoUnreferencedFilesOnDispose ?
+ public virtual bool AssertNoUnreferencedFilesOnDispose // LUCENENET specific: Renamed from AssertNoUnreferencedFilesOnClose
{
get => assertNoUnreferencedFilesOnClose; // LUCENENET specific - added getter (to follow MSDN property guidelines)
set => assertNoUnreferencedFilesOnClose = value;
diff --git a/src/Lucene.Net.Tests.Misc/Index/TestIndexSplitter.cs b/src/Lucene.Net.Tests.Misc/Index/TestIndexSplitter.cs
index 19d127c..b4fbf22 100644
--- a/src/Lucene.Net.Tests.Misc/Index/TestIndexSplitter.cs
+++ b/src/Lucene.Net.Tests.Misc/Index/TestIndexSplitter.cs
@@ -37,7 +37,7 @@ namespace Lucene.Net.Index
// so the unreferenced files are expected.
if (fsDir is MockDirectoryWrapper)
{
- ((MockDirectoryWrapper)fsDir).AssertNoUnreferencedFilesOnClose = (false);
+ ((MockDirectoryWrapper)fsDir).AssertNoUnreferencedFilesOnDispose = (false);
}
MergePolicy mergePolicy = new LogByteSizeMergePolicy();
diff --git a/src/Lucene.Net.Tests/Index/TestCrash.cs b/src/Lucene.Net.Tests/Index/TestCrash.cs
index 471e80e..cc7d4c3 100644
--- a/src/Lucene.Net.Tests/Index/TestCrash.cs
+++ b/src/Lucene.Net.Tests/Index/TestCrash.cs
@@ -92,7 +92,7 @@ namespace Lucene.Net.Index
// We create leftover files because merging could be
// running when we crash:
- dir.AssertNoUnreferencedFilesOnClose = false;
+ dir.AssertNoUnreferencedFilesOnDispose = false;
Crash(writer);
@@ -123,7 +123,7 @@ namespace Lucene.Net.Index
// We create leftover files because merging could be
// running / store files could be open when we crash:
- dir.AssertNoUnreferencedFilesOnClose = false;
+ dir.AssertNoUnreferencedFilesOnDispose = false;
dir.PreventDoubleWrite = false;
Console.WriteLine("TEST: now crash");
@@ -153,7 +153,7 @@ namespace Lucene.Net.Index
// We create leftover files because merging could be
// running when we crash:
- dir.AssertNoUnreferencedFilesOnClose = false;
+ dir.AssertNoUnreferencedFilesOnDispose = false;
writer.Dispose();
writer = InitIndex(Random, dir, false);
diff --git a/src/Lucene.Net.Tests/Index/TestDoc.cs b/src/Lucene.Net.Tests/Index/TestDoc.cs
index 4046194..a60372a 100644
--- a/src/Lucene.Net.Tests/Index/TestDoc.cs
+++ b/src/Lucene.Net.Tests/Index/TestDoc.cs
@@ -127,7 +127,7 @@ namespace Lucene.Net.Index
{
// We create unreferenced files (we don't even write
// a segments file):
- wrapper.AssertNoUnreferencedFilesOnClose = false;
+ wrapper.AssertNoUnreferencedFilesOnDispose = false;
}
IndexWriter writer = new IndexWriter(directory, NewIndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random)).SetOpenMode(OpenMode.CREATE).SetMaxBufferedDocs(-1).SetMergePolicy(NewLogMergePolicy(10)));
@@ -165,7 +165,7 @@ namespace Lucene.Net.Index
{
// We create unreferenced files (we don't even write
// a segments file):
- wrapper.AssertNoUnreferencedFilesOnClose = false;
+ wrapper.AssertNoUnreferencedFilesOnDispose = false;
}
writer = new IndexWriter(directory, NewIndexWriterConfig(TEST_VERSION_CURRENT, new MockAnalyzer(Random)).SetOpenMode(OpenMode.CREATE).SetMaxBufferedDocs(-1).SetMergePolicy(NewLogMergePolicy(10)));
diff --git a/src/Lucene.Net.Tests/Index/TestIndexWriterWithThreads.cs b/src/Lucene.Net.Tests/Index/TestIndexWriterWithThreads.cs
index 2f8a75a..7531d5b 100644
--- a/src/Lucene.Net.Tests/Index/TestIndexWriterWithThreads.cs
+++ b/src/Lucene.Net.Tests/Index/TestIndexWriterWithThreads.cs
@@ -437,7 +437,7 @@ namespace Lucene.Net.Index
// Since we throw exc during abort, eg when IW is
// attempting to delete files, we will leave
// leftovers:
- dir.AssertNoUnreferencedFilesOnClose = false;
+ dir.AssertNoUnreferencedFilesOnDispose = false;
if (m_doFail)
{
diff --git a/src/Lucene.Net.Tests/Index/TestStressIndexing.cs b/src/Lucene.Net.Tests/Index/TestStressIndexing.cs
index d408756..effd7c9 100644
--- a/src/Lucene.Net.Tests/Index/TestStressIndexing.cs
+++ b/src/Lucene.Net.Tests/Index/TestStressIndexing.cs
@@ -229,7 +229,7 @@ namespace Lucene.Net.Index
MockDirectoryWrapper wrapper = directory as MockDirectoryWrapper;
if (wrapper != null)
{
- wrapper.AssertNoUnreferencedFilesOnClose = true;
+ wrapper.AssertNoUnreferencedFilesOnDispose = true;
}
RunStressTest(directory, new ConcurrentMergeScheduler());
diff --git a/src/Lucene.Net.Tests/Index/TestTransactions.cs b/src/Lucene.Net.Tests/Index/TestTransactions.cs
index 6269dc2..ebd885e 100644
--- a/src/Lucene.Net.Tests/Index/TestTransactions.cs
+++ b/src/Lucene.Net.Tests/Index/TestTransactions.cs
@@ -304,8 +304,8 @@ namespace Lucene.Net.Index
// We throw exceptions in deleteFile, which creates
// leftover files:
- dir1.AssertNoUnreferencedFilesOnClose = false;
- dir2.AssertNoUnreferencedFilesOnClose = false;
+ dir1.AssertNoUnreferencedFilesOnDispose = false;
+ dir2.AssertNoUnreferencedFilesOnDispose = false;
InitIndex(dir1);
InitIndex(dir2);