[GitHub] mistercrunch commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice

[gi...@git.apache.org]

mistercrunch commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice
URL: https://github.com/apache/incubator-superset/pull/3461#discussion_r138948105
 
 

 ##########
 File path: superset/assets/javascripts/modules/superset.js
 ##########
 @@ -207,11 +203,16 @@ const px = function (state) {
         } else {
           this.force = force;
         }
+        const formDataExtra = Object.assign({}, formData);
+        const extraFilters = controller.effectiveExtraFilters(sliceId);
+        formDataExtra.filters = formDataExtra.filters.concat(extraFilters);
+        controls.find('a.exploreChart').attr('href', getExploreUrl(formDataExtra));
 
 Review comment:
   @xrmx  eventually this whole module will get refactored out as we write a 100% React dashboard app (currently we have a lot of non-react JS in that app...), this is ok as is for now. We'll have to nuke all the jQuery code out of there in the future...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services