You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Robert Surówka (Created JIRA)" <ji...@apache.org> on 2011/10/25 03:16:32 UTC
[jira] [Created] (HIVE-2525) Introduce proper error messages, when
explain fails on commands that otherwise could be succesful (commands that
are not analyzed by Semantic Analyzer)
Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
-------------------------------------------------------------------------------------------------------------------------------------------------------
Key: HIVE-2525
URL: https://issues.apache.org/jira/browse/HIVE-2525
Project: Hive
Issue Type: Improvement
Reporter: Robert Surówka
Assignee: Robert Surówka
Priority: Trivial
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2525) Introduce proper error messages,
when explain fails on commands that otherwise could be succesful (commands
that are not analyzed by Semantic Analyzer)
Posted by "Robert Surówka (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135341#comment-13135341 ]
Robert Surówka commented on HIVE-2525:
--------------------------------------
I think such an error is incorrect since "dfs -ls <PATH>" (without explain) would never throw such an error on it's own (and execution of "dfs..." doesn't go to semantic analysis), so I see no reason for explain of "dfs...." to go to semantic analysis and throw semantic analysis type error.
Furthermore having check for incorrect explains at the beginning saves a lot of time, otherwise all the analysis and various class instances would be need to be created only to find error that we can easily see from the very beginning. And if someone would like to add or remove a command that doesn't go to Driver to be compiled, he will need to add or remove an "if" in CliDriver anyway so it shouldn't be hard for him to notice that he also needs to update that list. Finally if that suggestion of fix will pass I can add appropriate tests, checking if explains errors of non-sematic-analisys commands are informative, so it will be easier to see if something is wrong after subsequent changes.
The bad thing is that after this change, even for valid explain query we will check "contains" on that list, but fortunately since it is short it doesn't cost too much time.
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2525) Introduce proper error messages,
when explain fails on commands that otherwise could be succesful (commands
that are not analyzed by Semantic Analyzer)
Posted by "Ning Zhang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141246#comment-13141246 ]
Ning Zhang commented on HIVE-2525:
----------------------------------
I agree with Namit. The right approach is to throw a better error message in the parser rather than adding a special checking for a specific negative case. There are a lot of such negative cases. If we add checks for all of them, it becomes cumbersome and redundant in terms of parser's functionality.
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2525) Introduce proper error messages,
when explain fails on commands that otherwise could be succesful (commands
that are not analyzed by Semantic Analyzer)
Posted by "Robert Surówka (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134681#comment-13134681 ]
Robert Surówka commented on HIVE-2525:
--------------------------------------
Diff request at https://reviews.apache.org/r/2561/diff/#index_header
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2525) Introduce proper error messages, when
explain fails on commands that otherwise could be succesful (commands that
are not analyzed by Semantic Analyzer)
Posted by "Robert Surówka (Assigned JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Surówka reassigned HIVE-2525:
------------------------------------
Assignee: (was: Robert Surówka)
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2525) Introduce proper error messages, when
explain fails on commands that otherwise could be succesful (commands that
are not analyzed by Semantic Analyzer)
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2525:
-----------------------------
Status: Open (was: Patch Available)
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2525) Introduce proper error messages, when
explain fails on commands that otherwise could be succesful (commands that
are not analyzed by Semantic Analyzer)
Posted by "Robert Surówka (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Surówka updated HIVE-2525:
---------------------------------
Attachment: HIVE-2525.1.patch
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2525) Introduce proper error messages, when
explain fails on commands that otherwise could be succesful (commands that
are not analyzed by Semantic Analyzer)
Posted by "Robert Surówka (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Surówka updated HIVE-2525:
---------------------------------
Status: Patch Available (was: Open)
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2525) Introduce proper error messages,
when explain fails on commands that otherwise could be succesful (commands
that are not analyzed by Semantic Analyzer)
Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135227#comment-13135227 ]
Namit Jain commented on HIVE-2525:
----------------------------------
hive> explain dfs -ls <PATH>;
FAILED: Parse Error: line 1:8 cannot recognize input near 'dfs' '-' 'ls' in statement
The above error is a legitimate parse error.
If we want to fix it with a better error message, we should catch the parser error and throw
a beter message (the way you have put it in CliDriver). The approach you have taken is difficult
to maintain in the long run.
> Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2525
> URL: https://issues.apache.org/jira/browse/HIVE-2525
> Project: Hive
> Issue Type: Improvement
> Reporter: Robert Surówka
> Assignee: Robert Surówka
> Priority: Trivial
> Attachments: HIVE-2525.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira