You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/05/08 00:05:26 UTC
Review Request 21177: Provide basic validation for cluster create via a
blueprint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21177/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-5706
https://issues.apache.org/jira/browse/AMBARI-5706
Repository: ambari
Description
-------
Do simple validation for cluster create with blueprint.
Validate the following:
- invalid blueprint name
- no host_groups field
- host group without name
- host group without hosts
- host group hosts without fqdn
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java f459f3c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java e644b08
Diff: https://reviews.apache.org/r/21177/diff/
Testing
-------
Functional Testing:
Tested that the above conditions resulted is the appropriate responses.
Also tested provisioning a basic cluster.
Unit Tests:
Added new unit tests.
All existing tests pass.
Results :
Tests run: 1597, Failures: 0, Errors: 0, Skipped: 9
...
Total run:548
Total errors:0
Total failures:0
OK
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:17.020s
[INFO] Finished at: Wed May 07 17:58:49 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
John Speidel
Re: Review Request 21177: Provide basic validation for cluster create via a
blueprint
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21177/#review42444
-----------------------------------------------------------
- John Speidel
On May 7, 2014, 10:05 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21177/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 10:05 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-5706
> https://issues.apache.org/jira/browse/AMBARI-5706
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Do simple validation for cluster create with blueprint.
>
> Validate the following:
> - invalid blueprint name
> - no host_groups field
> - host group without name
> - host group without hosts
> - host group hosts without fqdn
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java f459f3c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java e644b08
>
> Diff: https://reviews.apache.org/r/21177/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> Tested that the above conditions resulted is the appropriate responses.
> Also tested provisioning a basic cluster.
>
> Unit Tests:
> Added new unit tests.
> All existing tests pass.
>
> Results :
>
> Tests run: 1597, Failures: 0, Errors: 0, Skipped: 9
> ...
> Total run:548
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:17.020s
> [INFO] Finished at: Wed May 07 17:58:49 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 21177: Provide basic validation for cluster create via a
blueprint
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21177/#review42450
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On May 7, 2014, 10:05 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21177/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 10:05 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-5706
> https://issues.apache.org/jira/browse/AMBARI-5706
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Do simple validation for cluster create with blueprint.
>
> Validate the following:
> - invalid blueprint name
> - no host_groups field
> - host group without name
> - host group without hosts
> - host group hosts without fqdn
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java f459f3c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java e644b08
>
> Diff: https://reviews.apache.org/r/21177/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> Tested that the above conditions resulted is the appropriate responses.
> Also tested provisioning a basic cluster.
>
> Unit Tests:
> Added new unit tests.
> All existing tests pass.
>
> Results :
>
> Tests run: 1597, Failures: 0, Errors: 0, Skipped: 9
> ...
> Total run:548
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:17.020s
> [INFO] Finished at: Wed May 07 17:58:49 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>