You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/25 09:55:17 UTC

[GitHub] [pulsar] RobertIndie commented on pull request #9531: [DOCS] Restore format

RobertIndie commented on pull request #9531:
URL: https://github.com/apache/pulsar/pull/9531#issuecomment-785769369


   > @sijia-w Thank you for your efforts. I'm afraid the restore is not totally correct.
   > @RobertIndie fixed the token issues in #9313 for the upcoming 2.8.0 release. As discussed and confirmed in #9187, except token, others support JSON format before 2.7.0 release. So you do not need to restore other changes (except token) in this PR. You can double confirm it with @RobertIndie on it.
   
   As discussed with @sijia-w , I think it is better to change other authentication parameters to `string` type. While other authentication supports the JSON format in more recent versions, they may not have been supported in the early version. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org